Skip to content

perf(semantic): inline enter_kind for BreakStatement#17435

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_
Dec 28, 2025
Merged

perf(semantic): inline enter_kind for BreakStatement#17435
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 28, 2025

Ref #18098

This was referenced Dec 28, 2025
Merged
Merged
Merged
Merged
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 28, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Dec 28, 2025
Merged
@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 28, 2025
@camc314 camc314 marked this pull request as ready for review December 28, 2025 16:59
@camc314 camc314 requested a review from Dunqing as a code owner December 28, 2025 16:59
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #17435 will not alter performance

Comparing c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_ (ff185bf) with c/12-27-perf_semantic_inline_enter_kind_cfg_statement_handling (ed105c6)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_ branch from 67d2e29 to ff185bf Compare December 28, 2025 17:09
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_cfg_statement_handling branch from 61bb03e to ed105c6 Compare December 28, 2025 17:09
@camc314 camc314 mentioned this pull request Dec 28, 2025
Merged
@camc314 camc314 self-assigned this Dec 28, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 28, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 28, 6:44 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 28, 8:15 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Dec 28, 8:22 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 28, 8:31 PM UTC: Merged by the Graphite merge queue.

@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_ branch from ff185bf to 2cb2418 Compare December 28, 2025 20:01
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_cfg_statement_handling branch from ed105c6 to 27acfd6 Compare December 28, 2025 20:01
@graphite-app graphite-app bot changed the base branch from c/12-27-perf_semantic_inline_enter_kind_cfg_statement_handling to graphite-base/17435 December 28, 2025 20:08
@camc314 camc314 force-pushed the graphite-base/17435 branch from 27acfd6 to 4a9b302 Compare December 28, 2025 20:14
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_ branch from 2cb2418 to fb7be93 Compare December 28, 2025 20:14
@graphite-app graphite-app bot changed the base branch from graphite-base/17435 to main December 28, 2025 20:15
@camc314 camc314 mentioned this pull request Dec 28, 2025
Merged
Copilot AI review requested due to automatic review settings December 28, 2025 20:24
@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_ branch from fb7be93 to d66a691 Compare December 28, 2025 20:24
Copilot AI reviewed Dec 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit d66a691 into main Dec 28, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-27-perf_semantic_inline_enter_kind_for_breakstatement_ branch December 28, 2025 20:31
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@Boshen Boshen mentioned this pull request Dec 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

@camc314 camc314

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314