Skip to content

perf(mangler): early exit in liveness walk when scope already marked live#17382

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-26-perf_test
Dec 27, 2025
Merged

perf(mangler): early exit in liveness walk when scope already marked live#17382
graphite-app[bot] merged 1 commit intomainfrom
c/12-26-perf_test

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 26, 2025

Skip redundant ancestor chain walking when a scope is already marked in
the slot's liveness bitset - all its ancestors must already be marked too.

Copy link
Contributor Author

camc314 commented Dec 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 26, 2025

CodSpeed Performance Report

Merging #17382 will improve performance by 3.46%

Comparing c/12-26-perf_test (023996f) with main (50f0ddd)

Summary

⚡ 1 improvement
✅ 37 untouched
⏩ 7 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Efficiency
Simulation mangler[binder.ts] 718.3 µs 694.2 µs +3.46%

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 changed the title perf test perf(mangler): early exit in liveness walk when scope already marked live Dec 26, 2025
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Dec 26, 2025
@camc314 camc314 mentioned this pull request Dec 26, 2025
@camc314 camc314 self-assigned this Dec 26, 2025
@camc314 camc314 marked this pull request as ready for review December 26, 2025 22:50
@graphite-app graphite-app bot changed the base branch from c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets to graphite-base/17382 December 27, 2025 05:53
@graphite-app graphite-app bot force-pushed the graphite-base/17382 branch from 6c11a94 to 50f0ddd Compare December 27, 2025 06:04
@graphite-app graphite-app bot changed the base branch from graphite-base/17382 to main December 27, 2025 06:04
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 27, 2025
Copy link
Member

Boshen commented Dec 27, 2025

Merge activity

…live (#17382)

Skip redundant ancestor chain walking when a scope is already marked in
the slot's liveness bitset - all its ancestors must already be marked too.
@graphite-app graphite-app bot merged commit e073925 into main Dec 27, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-26-perf_test branch December 27, 2025 07:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants