Skip to content

perf(mangler): use combined exclusion set for name generation#17381

Closed
camc314 wants to merge 1 commit intoc/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_setsfrom
c/12-26-perf_mangler_use_combined_exclusion_set_for_name_generation
Closed

perf(mangler): use combined exclusion set for name generation#17381
camc314 wants to merge 1 commit intoc/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_setsfrom
c/12-26-perf_mangler_use_combined_exclusion_set_for_name_generation

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 26, 2025

Build a single FxHashSet containing all excluded names (unresolved references, keep_name_names, and conditionally root_bindings) instead of doing 3-5 separate hash lookups per candidate name in the generation loop.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Dec 26, 2025
Copy link
Contributor Author

camc314 commented Dec 26, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets branch from 614513b to 4044df2 Compare December 26, 2025 22:13
@camc314 camc314 force-pushed the c/12-26-perf_mangler_use_combined_exclusion_set_for_name_generation branch 2 times, most recently from 3d03a51 to e0032ba Compare December 26, 2025 22:13
Build a single FxHashSet containing all excluded names (unresolved references,
keep_name_names, and conditionally root_bindings) instead of doing 3-5 separate
hash lookups per candidate name in the generation loop.
@camc314 camc314 force-pushed the c/12-26-perf_mangler_use_combined_exclusion_set_for_name_generation branch from e0032ba to fbd84ef Compare December 26, 2025 22:14
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 26, 2025

CodSpeed Performance Report

Merging #17381 will degrade performance by 15.1%

Comparing c/12-26-perf_mangler_use_combined_exclusion_set_for_name_generation (fbd84ef) with c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets (4044df2)

Summary

❌ 3 regressions
✅ 35 untouched
⏩ 7 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Efficiency
Simulation mangler[cal.com.tsx] 2.8 ms 3.2 ms -12.25%
Simulation mangler[binder.ts] 717.7 µs 761.1 µs -5.7%
Simulation mangler[RadixUIAdoptionSection.jsx] 12.9 µs 15.2 µs -15.1%

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 closed this Dec 26, 2025
@camc314 camc314 deleted the c/12-26-perf_mangler_use_combined_exclusion_set_for_name_generation branch December 26, 2025 22:19
@camc314 camc314 self-assigned this Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant