Skip to content

perf(mangler): optimize slot assignment with pre-computed ancestor sets#17379

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets
Dec 27, 2025
Merged

perf(mangler): optimize slot assignment with pre-computed ancestor sets#17379
graphite-app[bot] merged 1 commit intomainfrom
c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 26, 2025

Screenshot 2025-12-26 at 22 08 31

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Dec 26, 2025
Copy link
Contributor Author

camc314 commented Dec 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 26, 2025

CodSpeed Performance Report

Merging #17379 will improve performance by 4.34%

Comparing c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets (50f0ddd) with main (c3ff642)1

Summary

⚡ 2 improvements
✅ 36 untouched
⏩ 7 skipped2

Benchmarks breakdown

Mode Benchmark BASE HEAD Efficiency
Simulation mangler[binder.ts] 749.3 µs 718.1 µs +4.34%
Simulation mangler[react.development.js] 263.4 µs 254.7 µs +3.41%

Footnotes

  1. No successful run was found on main (5f963dd) during the generation of this report, so c3ff642 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 changed the base branch from c/12-26-perf_mangler_avoid_tostring_allocations to graphite-base/17379 December 26, 2025 22:07
@camc314 camc314 force-pushed the c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets branch from bc6245f to 614513b Compare December 26, 2025 22:07
@camc314 camc314 changed the base branch from graphite-base/17379 to c/12-26-feat_allocator_bitset_add_clear_method_to_reset_all_bits December 26, 2025 22:07
@camc314 camc314 self-assigned this Dec 26, 2025
@camc314 camc314 marked this pull request as ready for review December 26, 2025 22:11
@camc314 camc314 force-pushed the c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets branch from 614513b to 4044df2 Compare December 26, 2025 22:13
@camc314 camc314 force-pushed the c/12-26-feat_allocator_bitset_add_clear_method_to_reset_all_bits branch from 7724cda to f7e5f3f Compare December 26, 2025 22:39
@camc314 camc314 force-pushed the c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets branch from 4044df2 to 6c11a94 Compare December 26, 2025 22:39
@Boshen Boshen assigned Boshen and unassigned camc314 Dec 27, 2025
@graphite-app graphite-app bot changed the base branch from c/12-26-feat_allocator_bitset_add_clear_method_to_reset_all_bits to graphite-base/17379 December 27, 2025 05:45
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 27, 2025
Copy link
Member

Boshen commented Dec 27, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 27, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/17379 to main December 27, 2025 05:52
@graphite-app graphite-app bot force-pushed the c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets branch from 6c11a94 to 50f0ddd Compare December 27, 2025 05:53
@graphite-app graphite-app bot merged commit 50f0ddd into main Dec 27, 2025
27 checks passed
@graphite-app graphite-app bot deleted the c/12-26-perf_mangler_optimize_slot_assignment_with_pre-computed_ancestor_sets branch December 27, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants