fix(linter/plugins): get correct plugin name in all cases

[overlookmotel]

A couple of changes to how plugin names are dealt with:

Package names

Don't use package name if the specifier used to load the plugin is a relative path.

If your project is called super-server, and you load a plugin from ../plugins/no-foo.js, that plugin shouldn't be called super-server - that's the name of the project, not the plugin.

Now it throws an error, telling you to give the plugin a name.

Ensure context.id matches the plugin name

Previously context.id might not match the actual plugin name (it could include e.g. eslint-plugin- prefix, for example). Now it always matches.

This required re-implementing normalize_plugin_name on JS side too.

Tests

Add a bunch of tests for every combination I could imagine of plugin.meta.name, package name, and alias. Those tests make sure context.id is same as the plugin name on Rust side.

Incomplete

There's 2 things remaining to get naming completely correct:

1. Support plugin names with slashes in them e.g. @scope/eslint-plugin-name (Linter plugins: Support plugins with / in name #14557).

2. It's possible for the same plugin to have different names in different places, because you can alias the same plugin twice with different names in a config, and an override. Plugin names (in context.id, and in // oxlint-disable comments) should reflect the plugin name as it is in the config which enabled that rule.

I'm leaving those 2 for now.

[overlookmotel]

• fix(linter/plugins): get correct plugin name in all cases #17033 👈 (View in Graphite)
• test(linter/plugins): rename fixtures for plugin aliases #17032
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR fixes the plugin naming logic for JS plugins to correctly determine the plugin name in all scenarios. The key change is passing the plugin name and whether it's an alias from the Rust side to JavaScript, rather than relying solely on information from plugin.meta.name or package.json after loading.

Key changes:

• Modified the plugin loading callback signature to include a pre-determined plugin name and a boolean flag indicating if it's an alias
• Moved plugin name determination logic to the Rust side (before loading), including normalization of package names
• Added normalizePluginName function on the JS side that mirrors the Rust implementation to handle plugin names defined in plugin.meta.name

Reviewed changes

Copilot reviewed 21 out of 40 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/external_linter.rs	Updated ExternalLinterLoadPluginCb type to accept plugin name and alias flag
crates/oxc_linter/src/config/plugins.rs	Added documentation cross-referencing JS implementation
crates/oxc_linter/src/config/config_builder.rs	Moved plugin name determination logic before plugin loading; normalizes package names for non-relative specifiers
apps/oxlint/src/run.rs	Updated JsLoadPluginCb type signature to match new callback interface
apps/oxlint/src/js_plugins/external_linter.rs	Updated wrapper function to pass new parameters to JS callback
apps/oxlint/src-js/plugins/load.ts	Added normalizePluginName function; updated loadPlugin, registerPlugin, and getPluginName to handle alias priority correctly
apps/oxlint/src-js/package/rule_tester.ts	Updated registerPlugin call to include new parameters
apps/oxlint/src-js/cli.ts	Updated loadPluginWrapper signature to match new interface
apps/oxlint/src-js/bindings.d.ts	Updated TypeScript type definition for JsLoadPluginCb
apps/oxlint/test/fixtures/plugin_name/*	Added comprehensive test case covering all plugin naming scenarios
apps/oxlint/test/fixtures/plugin_name_missing/*	Added test for relative path plugin without name
apps/oxlint/test/fixtures/plugin_name_missing2/*	Added test for npm package plugin without name
apps/oxlint/test/fixtures/plugin_name_alias/*	Removed (likely consolidated into main plugin_name test)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17033 will not alter performance

_{Comparing 12-17-fix_linter_plugins_get_correct_plugin_name_in_all_cases (c13087b) with main (4d389f7)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on 12-17-test_linter_plugins_rename_fixtures_for_plugin_aliases (038f34a) during the generation of this report, so main (4d389f7) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[overlookmotel]

I'm going to merge this, as I want copilot to build #17035 on top of this. @camc314 if you have any comments/amends, please shout after the fact.

[overlookmotel]

Merge activity

• Dec 18, 8:57 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 18, 8:57 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Dec 18, 9:05 AM UTC: Merged by the Graphite merge queue.

[camc314]

✅This hurts my brain to think about