Skip to content

test(linter/plugins): rename fixtures for plugin aliases#17032

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-17-test_linter_plugins_rename_fixtures_for_plugin_aliases
Dec 18, 2025
Merged

test(linter/plugins): rename fixtures for plugin aliases#17032
graphite-app[bot] merged 1 commit intomainfrom
12-17-test_linter_plugins_rename_fixtures_for_plugin_aliases

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 18, 2025

Follow-on after #15569. Rename test fixtures. Remove the custom_plugin_ prefix on fixture names, and standardize naming of one other.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel
Copy link
Member Author

overlookmotel commented Dec 18, 2025

@camc314 I know you're going to hate this, but none of the other fixtures have the custom_plugin_ prefix. It doesn't make sense to me to only have 2 with that prefix, as that suggests that none of the other fixtures relate to custom plugins.

If you want to make a PR to rename all the fixtures related to JS plugins, I won't fight you!

@overlookmotel overlookmotel force-pushed the 12-17-test_linter_plugins_rename_fixtures_for_plugin_aliases branch from b99e157 to 038f34a Compare December 18, 2025 02:14
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 18, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 18, 2025

Merge activity

Follow-on after #15569. Rename test fixtures. Remove the `custom_plugin_` prefix on fixture names, and standardize naming of one other.
@graphite-app graphite-app bot force-pushed the 12-17-test_linter_plugins_rename_fixtures_for_plugin_aliases branch from 038f34a to 415f2f0 Compare December 18, 2025 08:58
@graphite-app graphite-app bot merged commit 415f2f0 into main Dec 18, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 12-17-test_linter_plugins_rename_fixtures_for_plugin_aliases branch December 18, 2025 09:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 18, 2025
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ I think I had these named the old way before you renamed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants