Skip to content

Comments

docs(linter): document intentional exclusion of ignoreCase option in jsx-no-duplicate-props#17046

Merged
camc314 merged 2 commits intomainfrom
copilot/add-ignore-case-option
Dec 18, 2025
Merged

docs(linter): document intentional exclusion of ignoreCase option in jsx-no-duplicate-props#17046
camc314 merged 2 commits intomainfrom
copilot/add-ignore-case-option

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

The react/jsx-no-duplicate-props rule was missing documentation about the intentionally unsupported ignoreCase option from ESLint, causing confusion for users migrating from ESLint configurations (e.g., Airbnb preset).

Changes

  • Added "Differences from ESLint" section documenting that ignoreCase is not supported
  • Clarified that props with different cases (e.g., foo and Foo) are treated as distinct, which is correct behavior since JSX props are case-sensitive

The rule already implements case-sensitive prop checking (as evidenced by existing test cases like <App A a /> passing). This change only adds documentation to make the intentional design decision explicit.

Original prompt

This section details on the original issue you should resolve

<issue_title>linter: react/jsx-no-duplicate-props rule lacks ignoreCase option</issue_title>
<issue_description>### What version of Oxlint are you using?

0.33.0

What command did you run?

oxlint

What does your .oxlintrc.json config file look like?

{
  "$schema": "./node_modules/oxlint/configuration_schema.json",
  "plugins": [
    "react"
  ],
  "rules": {
    "react/jsx-no-duplicate-props": ["error", { "ignoreCase": true }],
  }
}

What happened?

See the docs for the original rule: https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-duplicate-props.md

The oxc rule has no ignoreCase config option.

I assume this was a mistake caused by the @eslint-react/eslint-plugin plugin having the same rule but lacking ignoreCase? But ignoreCase should be supported, otherwise the implementation differs. The widely-used eslint airbnb config sets this option explicitly, which is how I noticed the problem after trying to migrate an ESLint config.

ignoreCase should default to false.

Alt implementation which has no ignoreCase option:

<agent_instructions>See the most recent comment </agent_instructions>

Comments on the Issue (you are @copilot in this section)

@camc314 I'm really tempted to say we just shouldn't support this. Props with different case are different, so why does an `ignoreCase` option make sense.

biome also doesn't support this option</comment_new>
<comment_new>@connorshea

I'm really tempted to say we just shouldn't support this. Props with different case are different, so why does an ignoreCase option make sense.

biome also doesn't support this option

Honestly, that's very fair. I think it probably makes sense to exclude this option. The only reason I noticed it was because the airbnb config is used for eslint at work and so I ran into one case where we disabled the rule with a disable-directive because of it. I have no idea why the airbnb config was set up with this config option set to true, but it was.

We should probably note in the docs that we are intentionally excluding it, though.</comment_new>
<comment_new>@camc314
@copilot add docs to mention that we explicitly don't support this option</comment_new>


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add ignoreCase option to linter rule react/jsx-no-duplicate-props docs(linter): document intentional exclusion of ignoreCase option in jsx-no-duplicate-props Dec 18, 2025
Copilot AI requested a review from camc314 December 18, 2025 09:35
@camc314 camc314 marked this pull request as ready for review December 18, 2025 10:56
Copilot AI review requested due to automatic review settings December 18, 2025 10:56
Copilot AI and others added 2 commits December 18, 2025 10:56
…uplicate-props

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Signed-off-by: Cameron <cameron.clark@hey.com>
@camc314 camc314 force-pushed the copilot/add-ignore-case-option branch from 047c12e to 91fade6 Compare December 18, 2025 10:56
@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Dec 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation to clarify the intentional exclusion of the ignoreCase option from the react/jsx-no-duplicate-props rule, addressing user confusion when migrating from ESLint configurations.

  • Added a "Differences from eslint-plugin-react" documentation section
  • Clarified that props with different cases are treated as distinct (case-sensitive behavior)
  • Explained that this design decision is intentional since JSX props are inherently case-sensitive

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 merged commit b5f3c91 into main Dec 18, 2025
17 of 18 checks passed
@camc314 camc314 deleted the copilot/add-ignore-case-option branch December 18, 2025 11:01
overlookmotel added a commit that referenced this pull request Dec 19, 2025
# Oxlint
### 🚀 Features

- 6cc3fdf linter/no-inferrable-types: Implement fixer (#17090) (camc314)
- 2067997 linter/no-negation-in-equality-check: Implement suggestion
(#17084) (camc314)
- 552f9ef vscode: Auto-generate VSCode README configuration from
package.json (#16970) (Copilot)
- 9190c4b linter/no-unnecessary-array-flat-depth: Implement fixer
(#17057) (camc314)
- ed789de linter/misrefactored-assign-op: Implement fixer (#17056)
(camc314)
- a0f74a0 linter/config: Allow aliasing plugin names to allow names the
same as builtin plugins (#15569) (Cameron)
- a43d251 linter/plugins: `RuleTester` support `languageOptions.globals`
(#17009) (overlookmotel)
- 35070d9 linter/bad-bitwise-operator: Implement fixer (#17006)
(camc314)
- 322d995 linter/prefer-enum-initializers: Implement fixer (#17004)
(camc314)
- ae1e5bc vscode: Add support for tsgolint binary configuration (#16921)
(ColemanDunn)
- 3bfe31e linter/eslint-plugin-vitest: Add prefer-called-with as vitest
compatible jest rule (#16993) (Said Atrahouch)
- 0cd075f linter/eslint-plugin-jest: Add fix capabilities to
prefer-called-with rule (#16987) (Said Atrahouch)
- 357564b linter: Add options for
`typescript/require-array-sort-compare` rule. (#16980) (connorshea)
- 2b0ffba linter: Add options for
`typescript/no-meaningless-void-operator` rule. (#16981) (connorshea)
- 8bc4287 linter/plugins: Validate options against schema (#16974)
(overlookmotel)
- fdc7d08 linter: Implement eslint/capitalized-comments (#16896) (Tu
Shaokun)
- f8b6561 linter: Add support for `test.for` in vitest (#16925)
(camchenry)
- 7ee0379 linter/eslint-plugin-vitest: Implement prefer-spy-on (#16426)
(Said Atrahouch)
- fc96ee0 linter: Implement jest/prefer-to-have-been-called-times
(#16938) (秦宇航)
- 291b57b ast_tools: Generate TS declaration files for deserializer and
walk files (#16912) (camc314)
- e31da2a linter: Implement jest/perfer-to-have-been-called (#16899)
(秦宇航)
- 1a31306 linter/eslint-plugin-vitest: Add require-hook as vitest
compatible jest rule (#16880) (Said Atrahouch)
- cd3db21 linter: Add ignoredTypeNames option to no-base-to-string rule
(#16898) (camc314)
- 763b25a linter: Implement eslint/no-inline-comments (#16885) (Tu
Shaokun)

### 🐛 Bug Fixes

- fb9e193 linter: OOM problems with custom plugins (#17082)
(overlookmotel)
- 005ec25 linter: Permit `$schema` `.oxlintrc.json` struct (#17060)
(Copilot)
- fd03131 linter/plugins: Handle plugin names containing slashes
(#17073) (overlookmotel)
- b2a4fac linter/plugins: Error if plugin name alias is not normalized
(#17071) (overlookmotel)
- e046c4e linter/no-misused-spread: Add rule options support (#17054)
(camc314)
- 5c1a9e0 linter/no-deprecated: Add rule options support (#17053)
(camc314)
- 8c9cafe linter: `import/consistent-type-specifier-style`: add support
for declaration files (#16979) (camchenry)
- dab4780 linter/no-empty-pattern: Misleading help message for arrays
(#17039) (Copilot)
- 67f8c5d linter/plugins: Get correct plugin name in all cases (#17033)
(overlookmotel)
- 674dab9 linter/plugins: Fix indentation in error message (#17018)
(overlookmotel)
- 6524f72 linter/plugins: Add `@types/node` dev dependency to `oxlint`
package (#17016) (overlookmotel)
- 7a35513 linter/plugins: Better error for `null` in `globals` in
`RuleTester` (#17011) (overlookmotel)
- 42603ba linter/plugins: Always define `languageOptions.globals`
(#17008) (overlookmotel)
- 4cdc2f8 linter: Fix VITEST override rule list and add test for
alphabetizing the two lists (#16975) (Connor Shea)
- e466562 linter/consistent-type-definitions: Handle parenthesized types
in rule (#16998) (camc314)
- fce267c linter: Correct vitest plugin source to be
`@vitest/eslint-plugin` (#16976) (connorshea)
- 477bb57 linter: Fix `vitest/no-restricted-vi-methods` and add tests
for it. (#16971) (connorshea)
- 7d6974d linter: Ignore oxlint directive comments in
capitalized-comments (#16989) (Tu Shaokun)
- 23ac6b1 linter/plugins: Apply defaults from `meta.schema` to options
(#16930) (overlookmotel)
- 2f946cf linter/plugins: Error if `defaultOptions` is not
JSON-serializable (#16959) (overlookmotel)
- d8b8a57 linter/plugins: Freeze whole of merged options (#16958)
(overlookmotel)
- d446c43 linter: Prevent extra fields from being present on oxlint
config file (#16874) (connorshea)
- b845871 linter/plugins: Correctly handle object with `__proto__` keys
in options merging (#16928) (overlookmotel)
- c897794 linter: Fix eslint/sort-imports allowSeparatedGroups not
working with single empty line (#16012) (Duc Nghiem Xuan)
- 0c347a1 linter/array-type: Handle satisfies expression (#16903)
(camc314)

### ⚡ Performance

- 70d853c linter: Avoid cloning source text when cloning AST into
fixed-size allocator (#17088) (overlookmotel)
- 4d389f7 linter: Less bounds checks in `normalize_plugin_name` (#17030)
(overlookmotel)
- fd8e9c6 linter/plugins: Speed up cloning JSON objects (#16997)
(overlookmotel)
- d77e22d linter/plugins: Use `DEFAULT_OPTIONS` for rules with empty
array as default options (#16913) (overlookmotel)

### 📚 Documentation

- 6d053b4 linter: Fix typo in doc comment (#17091) (overlookmotel)
- b5f3c91 linter: Document intentional exclusion of ignoreCase option in
jsx-no-duplicate-props (#17046) (Copilot)
- a0bf5d8 linter: Fix the config option docs for no-inline-comments
rule. (#16983) (connorshea)
- ca26a11 linter/plugins: Fix typo in doc comment (#16966)
(overlookmotel)
- 3183bf8 linter/plugins: Fix typo in JSDoc comment (#16900)
(overlookmotel)
# Oxfmt
### 🚀 Features

- 15dfb55 oxfmt: Respect single nearest `.editorconfig` (#17043)
(leaysgur)
- 8c33ff4 oxfmt: Expose Node.js API: `format(fileName, sourceText,
options?)` (#16939) (leaysgur)

### 🐛 Bug Fixes

- d340c87 oxfmt: Update api `FormatOptions` type with `& Record<string,
unknown>` (#17036) (leaysgur)
- 827a256 oxfmt: Place ignorePatterns at bottom of JSON in --migrate
prettier (#16926) (Boshen)

Co-authored-by: overlookmotel <557937+overlookmotel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: react/jsx-no-duplicate-props rule lacks ignoreCase option

2 participants