Skip to content

fix(formatter): disable layout assertions on some 32-bit platforms#16625

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms
Dec 9, 2025
Merged

fix(formatter): disable layout assertions on some 32-bit platforms#16625
graphite-app[bot] merged 1 commit intomainfrom
12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 9, 2025

close: #15984. Same as #15984

Copilot AI review requested due to automatic review settings December 9, 2025 02:51
@github-actions github-actions bot added the A-formatter Area - Formatter label Dec 9, 2025
Copy link
Member Author

Dunqing commented Dec 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes compilation failures on 32-bit platforms where u64 has 4-byte alignment (such as x86) by conditionally disabling layout assertions that would fail on those platforms. The fix aligns with the existing pattern used throughout the codebase in generated assertion files.

Key changes:

  • Modified two compile-time assertion blocks to only run on 32-bit platforms with 8-byte u64 alignment or WASM
  • This prevents assertion failures on 32-bit platforms with 4-byte u64 alignment where struct layout differs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #16625 will not alter performance

Comparing 12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms (152f6f3) with main (feffe48)1

Summary

✅ 38 untouched
⏩ 7 skipped2

Footnotes

  1. No successful run was found on main (6f3aaba) during the generation of this report, so feffe48 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Copilot review seems valid? 👀
  • nits: IIRC, <> for <link> is only needed inside /// comment for Rust

@Dunqing Dunqing force-pushed the 12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms branch from b719091 to 152f6f3 Compare December 9, 2025 05:38
@Dunqing
Copy link
Member Author

Dunqing commented Dec 9, 2025

  • Copilot review seems valid? 👀
  • nits: IIRC, <> for <link> is only needed inside /// comment for Rust

Thank you for reminding!

@Dunqing Dunqing requested a review from leaysgur December 9, 2025 05:47
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
Copy link
Member

leaysgur commented Dec 9, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms branch from 152f6f3 to 0d5da26 Compare December 9, 2025 06:04
@graphite-app graphite-app bot merged commit 0d5da26 into main Dec 9, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms branch December 9, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evaluation panicked: FormatElement size exceeds 24 bytes when building oxlint version 1.29.0 on 32-bit x86 GNU/Linux

3 participants