fix(formatter): disable layout assertions on some 32-bit platforms#16625
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR fixes compilation failures on 32-bit platforms where u64 has 4-byte alignment (such as x86) by conditionally disabling layout assertions that would fail on those platforms. The fix aligns with the existing pattern used throughout the codebase in generated assertion files.
Key changes:
- Modified two compile-time assertion blocks to only run on 32-bit platforms with 8-byte
u64alignment or WASM - This prevents assertion failures on 32-bit platforms with 4-byte
u64alignment where struct layout differs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #16625 will not alter performanceComparing Summary
Footnotes
|
leaysgur
left a comment
There was a problem hiding this comment.
- Copilot review seems valid? 👀
- nits: IIRC,
<>for<link>is only needed inside/// commentfor Rust
b719091 to
152f6f3
Compare
Thank you for reminding! |
Merge activity
|
152f6f3 to
0d5da26
Compare

close: #15984. Same as #15984