Skip to content

fix(formatter): disable layout assertions on some 32-bit platforms #16625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 9, 2025
Merged

fix(formatter): disable layout assertions on some 32-bit platforms #16625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crates/oxc_formatter/src/formatter/format_element/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ const _: () = {
size_of::<FormatElement>() == 40,
"`FormatElement` size exceeds 40 bytes, expected 40 bytes in 64-bit platforms"
);
} else {
} else if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Some 32-bit platforms have 8-byte alignment for `u64` and `f64`, while others have 4-byte alignment.
//
// Skip these assertions on 32-bit platforms where `u64` / `f64` have 4-byte alignment, because
// some layout calculations may be incorrect. https://github.com/oxc-project/oxc/pull/13716
assert!(
size_of::<FormatElement>() == 24,
"`FormatElement` size exceeds 24 bytes, expected 24 bytes in 32-bit platforms"
Expand All @@ -40,7 +44,11 @@ const _: () = {
size_of::<FormatElement>() == 24,
"`FormatElement` size exceeds 24 bytes, expected 24 bytes in 64-bit platforms"
);
} else {
} else if cfg!(target_family = "wasm") || align_of::<u64>() == 8 {
// Some 32-bit platforms have 8-byte alignment for `u64` and `f64`, while others have 4-byte alignment.
//
// Skip these assertions on 32-bit platforms where `u64` / `f64` have 4-byte alignment, because
// some layout calculations may be incorrect. https://github.com/oxc-project/oxc/pull/13716
assert!(
size_of::<FormatElement>() == 16,
"`FormatElement` size exceeds 16 bytes, expected 16 bytes in 32-bit platforms"
Expand Down
Loading