Skip to content

perf(formatter): skip propagate the most expanded variant of best_fitting#16626

Closed
Dunqing wants to merge 3 commits intographite-base/16626from
12-09-perf_formatter_skip_propagate_the_most_expanded_variant_of_best_fitting
Closed

perf(formatter): skip propagate the most expanded variant of best_fitting#16626
Dunqing wants to merge 3 commits intographite-base/16626from
12-09-perf_formatter_skip_propagate_the_most_expanded_variant_of_best_fitting

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 9, 2025

No description provided.

@github-actions github-actions bot added A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 9, 2025
Copy link
Member Author

Dunqing commented Dec 9, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #16626 will not alter performance

Comparing 12-09-perf_formatter_skip_propagate_the_most_expanded_variant_of_best_fitting (76e0cab) with 12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms (b719091)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing changed the base branch from 12-09-fix_formatter_disable_layout_assertions_on_some_32-bit_platforms to graphite-base/16626 December 9, 2025 05:38
@Dunqing
Copy link
Member Author

Dunqing commented Dec 9, 2025

It isn't correct

@Dunqing Dunqing closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant