feat(minfier): support `.` separated values for `compress.treeshake.manualPureFunctions` by sapphi-red · Pull Request #16529 · oxc-project/oxc

sapphi-red · 2025-12-05T06:45:07Z

sapphi-red · 2025-12-05T06:45:27Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-12-05T06:50:33Z

CodSpeed Performance Report

Merging #16529 will not alter performance

_{Comparing 12-05-fix_minfier_support_.separated_values_for_compress.treeshake.manualpurefunctions (fa3aadc) with main (66b64ef)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

No successful run was found on main (af76b0e) during the generation of this report, so 66b64ef was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

This PR adds support for dot-separated values (e.g., "console.log") in the compress.treeshake.manualPureFunctions configuration option for the minifier. Previously, only simple identifier names were supported (e.g., "foo"). The implementation now handles member expression paths, allowing users to mark specific methods as pure functions for tree-shaking purposes.

Key changes:

New is_pure_function utility in oxc_ecmascript/src/side_effects/pure_function.rs that matches callees against dotted pure function names
Updated Ctx::manual_pure_functions to use the new utility
Comprehensive test coverage including edge cases and examples from Terser and Rollup

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_ecmascript/src/side_effects/pure_function.rs	New module implementing dotted name matching for pure functions with support for member expressions, chained calls, and optional chaining
crates/oxc_ecmascript/src/side_effects/mod.rs	Exports the new `is_pure_function` utility
crates/oxc_minifier/src/ctx.rs	Refactored to use the new `is_pure_function` utility with redundant empty check
crates/oxc_minifier/tests/ecmascript/is_pure_function.rs	Comprehensive unit tests for the new pure function matching logic
crates/oxc_minifier/tests/ecmascript/may_have_side_effects.rs	Integration tests for dotted name support and updated to use new utility
crates/oxc_minifier/tests/ecmascript/mod.rs	Adds new test module
crates/oxc_minifier/tests/peephole/manual_pure_functions.rs	End-to-end tests from Terser demonstrating the feature
crates/oxc_minifier/tests/peephole/mod.rs	Adds new test module

Note: There is a typo in the PR title: "minfier" should be "minifier".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_minifier/src/ctx.rs

graphite-app · 2025-12-05T09:57:19Z

Merge activity

Dec 5, 9:57 AM UTC: Boshen added this pull request to the Graphite merge queue.
Dec 5, 10:04 AM UTC: Merged by the Graphite merge queue.

…anualPureFunctions` (#16529) close #16100

### 💥 BREAKING CHANGES - 083fea9 napi/parser: [**BREAKING**] Represent empty optional fields on JS side as `null` (#16411) (overlookmotel) ### 🚀 Features - 7a2afee parser: Add TS1174 error for classes extending multiple base classes (#15993) (sapphi-red) - da87812 semantic: Add TS2309 error for export assignment with other exports (#15992) (sapphi-red) - d6d2bcd minifier: Remove unused function calls that are marked by `manual_pure_functions` (#16534) (sapphi-red) - c90f053 minifier: Support `.` separated values for `compress.treeshake.manualPureFunctions` (#16529) (sapphi-red) - a607cc4 codegen: Preserve comments between CatchClause's param and body (#16167) (copilot-swe-agent) - 8c10694 semantic: Expose get_comment_at method (#16439) (camc314) - 3981e7a ast: Add get_comment_at to lookup a comment by span (#16438) (camc314) ### 🐛 Bug Fixes - 699406a napi/parser: Move `ExportEntry::module_request` field to first (#16412) (overlookmotel) - 12bd794 napi/parser: Move `ExportEntry::module_request` field to last (#16403) (overlookmotel) ### ⚡ Performance - 790beeb napi/parser: Do not remove extraneous options on JS side (#16447) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

…anualPureFunctions` (oxc-project#16529) close oxc-project#16100

### 💥 BREAKING CHANGES - 083fea9 napi/parser: [**BREAKING**] Represent empty optional fields on JS side as `null` (oxc-project#16411) (overlookmotel) ### 🚀 Features - 7a2afee parser: Add TS1174 error for classes extending multiple base classes (oxc-project#15993) (sapphi-red) - da87812 semantic: Add TS2309 error for export assignment with other exports (oxc-project#15992) (sapphi-red) - d6d2bcd minifier: Remove unused function calls that are marked by `manual_pure_functions` (oxc-project#16534) (sapphi-red) - c90f053 minifier: Support `.` separated values for `compress.treeshake.manualPureFunctions` (oxc-project#16529) (sapphi-red) - a607cc4 codegen: Preserve comments between CatchClause's param and body (oxc-project#16167) (copilot-swe-agent) - 8c10694 semantic: Expose get_comment_at method (oxc-project#16439) (camc314) - 3981e7a ast: Add get_comment_at to lookup a comment by span (oxc-project#16438) (camc314) ### 🐛 Bug Fixes - 699406a napi/parser: Move `ExportEntry::module_request` field to first (oxc-project#16412) (overlookmotel) - 12bd794 napi/parser: Move `ExportEntry::module_request` field to last (oxc-project#16403) (overlookmotel) ### ⚡ Performance - 790beeb napi/parser: Do not remove extraneous options on JS side (oxc-project#16447) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Dec 5, 2025

sapphi-red force-pushed the 12-05-fix_minfier_support_._separated_values_for_compress.treeshake.manualpurefunctions_ branch from 04b0f6a to fa3aadc Compare December 5, 2025 09:19

sapphi-red mentioned this pull request Dec 5, 2025

feat(minifier): remove unused function calls that are marked by manual_pure_functions #16534

Merged

sapphi-red marked this pull request as ready for review December 5, 2025 09:24

Copilot AI review requested due to automatic review settings December 5, 2025 09:25

Copilot started reviewing on behalf of sapphi-red December 5, 2025 09:25 View session

Copilot finished reviewing on behalf of sapphi-red December 5, 2025 09:28

Copilot AI reviewed Dec 5, 2025

View reviewed changes

crates/oxc_minifier/src/ctx.rs Show resolved Hide resolved

sapphi-red assigned Boshen Dec 5, 2025

sapphi-red requested a review from Boshen December 5, 2025 09:33

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2025

feat(minfier): support . separated values for `compress.treeshake.m…

c90f053

…anualPureFunctions` (#16529) close #16100

graphite-app bot force-pushed the 12-05-fix_minfier_support_._separated_values_for_compress.treeshake.manualpurefunctions_ branch from fa3aadc to c90f053 Compare December 5, 2025 09:58

graphite-app bot merged commit c90f053 into main Dec 5, 2025
20 checks passed

graphite-app bot deleted the 12-05-fix_minfier_support_._separated_values_for_compress.treeshake.manualpurefunctions_ branch December 5, 2025 10:04

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 5, 2025

sapphi-red mentioned this pull request Dec 5, 2025

minifier: compress.treeshake.manualPureFunctions does not work with values like foo.bar #16100

Closed

Boshen mentioned this pull request Dec 8, 2025

release(crates): oxc v0.102.0 #16595

Merged

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025

feat(minfier): support . separated values for `compress.treeshake.m…

a10b443

…anualPureFunctions` (oxc-project#16529) close oxc-project#16100

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(minfier): support `.` separated values for `compress.treeshake.manualPureFunctions`#16529

feat(minfier): support `.` separated values for `compress.treeshake.manualPureFunctions`#16529
graphite-app[bot] merged 1 commit intomainfrom
12-05-fix_minfier_support_._separated_values_for_compress.treeshake.manualpurefunctions_

sapphi-red commented Dec 5, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Dec 5, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sapphi-red commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #16529 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sapphi-red commented Dec 5, 2025 •

edited

Loading

sapphi-red commented Dec 5, 2025 •

edited

Loading

codspeed-hq bot commented Dec 5, 2025 •

edited

Loading

graphite-app bot commented Dec 5, 2025 •

edited

Loading