feat(ast): add get_comment_at to lookup a comment by span by camc314 · Pull Request #16438 · oxc-project/oxc

camc314 · 2025-12-03T11:41:32Z

🤖 generated with help from Claude Opus 4.5

camc314 · 2025-12-03T11:41:49Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

camc314 · 2025-12-03T11:45:24Z

@overlookmotel mind taking a quick look at this PR for a sanity check? - Thanks

Copilot

Pull request overview

This PR adds a new get_comment_at function to the AST trivia module that returns a reference to the comment containing a given position. The function uses binary search for efficient O(log n) lookup and refactors the existing is_inside_comment function to use it, reducing code duplication.

Key changes:

Adds get_comment_at function that returns Option<&Comment> for a position
Refactors is_inside_comment to delegate to get_comment_at().is_some()
Exports the new function in the public API

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
crates/oxc_ast/src/trivia.rs	Implements `get_comment_at` function with binary search, refactors `is_inside_comment` to use it, and adds comprehensive test coverage
crates/oxc_ast/src/lib.rs	Exports the new `get_comment_at` function in the public API

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_ast/src/trivia.rs

codspeed-hq · 2025-12-03T11:50:00Z

CodSpeed Performance Report

Merging #16438 will not alter performance

_{Comparing c/12-03-feat_ast_add_get_comment_at_function_for_efficient_comment_span_lookup (9517f01) with main (5017db8)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

No successful run was found on main (329dbd5) during the generation of this report, so 5017db8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

overlookmotel

Looks good to me!

camc314 · 2025-12-03T13:46:36Z

Merge activity

Dec 3, 1:46 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 3, 1:48 PM UTC: camc314 added this pull request to the Graphite merge queue.
Dec 3, 1:56 PM UTC: Merged by the Graphite merge queue.

🤖 generated with help from Claude Opus 4.5

camc314 · 2025-12-03T13:49:08Z

Looks good to me!

Thanks!

This just exposes the method introduced into `oxc_ast` in #16438 🤖 generated with help from Claude Opus 4.5

### 💥 BREAKING CHANGES - 083fea9 napi/parser: [**BREAKING**] Represent empty optional fields on JS side as `null` (#16411) (overlookmotel) ### 🚀 Features - 7a2afee parser: Add TS1174 error for classes extending multiple base classes (#15993) (sapphi-red) - da87812 semantic: Add TS2309 error for export assignment with other exports (#15992) (sapphi-red) - d6d2bcd minifier: Remove unused function calls that are marked by `manual_pure_functions` (#16534) (sapphi-red) - c90f053 minifier: Support `.` separated values for `compress.treeshake.manualPureFunctions` (#16529) (sapphi-red) - a607cc4 codegen: Preserve comments between CatchClause's param and body (#16167) (copilot-swe-agent) - 8c10694 semantic: Expose get_comment_at method (#16439) (camc314) - 3981e7a ast: Add get_comment_at to lookup a comment by span (#16438) (camc314) ### 🐛 Bug Fixes - 699406a napi/parser: Move `ExportEntry::module_request` field to first (#16412) (overlookmotel) - 12bd794 napi/parser: Move `ExportEntry::module_request` field to last (#16403) (overlookmotel) ### ⚡ Performance - 790beeb napi/parser: Do not remove extraneous options on JS side (#16447) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

…t#16438) 🤖 generated with help from Claude Opus 4.5

This just exposes the method introduced into `oxc_ast` in oxc-project#16438 🤖 generated with help from Claude Opus 4.5

### 💥 BREAKING CHANGES - 083fea9 napi/parser: [**BREAKING**] Represent empty optional fields on JS side as `null` (oxc-project#16411) (overlookmotel) ### 🚀 Features - 7a2afee parser: Add TS1174 error for classes extending multiple base classes (oxc-project#15993) (sapphi-red) - da87812 semantic: Add TS2309 error for export assignment with other exports (oxc-project#15992) (sapphi-red) - d6d2bcd minifier: Remove unused function calls that are marked by `manual_pure_functions` (oxc-project#16534) (sapphi-red) - c90f053 minifier: Support `.` separated values for `compress.treeshake.manualPureFunctions` (oxc-project#16529) (sapphi-red) - a607cc4 codegen: Preserve comments between CatchClause's param and body (oxc-project#16167) (copilot-swe-agent) - 8c10694 semantic: Expose get_comment_at method (oxc-project#16439) (camc314) - 3981e7a ast: Add get_comment_at to lookup a comment by span (oxc-project#16438) (camc314) ### 🐛 Bug Fixes - 699406a napi/parser: Move `ExportEntry::module_request` field to first (oxc-project#16412) (overlookmotel) - 12bd794 napi/parser: Move `ExportEntry::module_request` field to last (oxc-project#16403) (overlookmotel) ### ⚡ Performance - 790beeb napi/parser: Do not remove extraneous options on JS side (oxc-project#16447) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-ast Area - AST C-enhancement Category - New feature or request labels Dec 3, 2025

camc314 force-pushed the c/12-03-feat_ast_add_get_comment_at_function_for_efficient_comment_span_lookup branch from 7c4bbbe to 2a47841 Compare December 3, 2025 11:44

camc314 changed the title ~~feat(ast): add get_comment_at function for efficient comment span lookup~~ feat(ast): add get_comment_at to lookup a comment by span Dec 3, 2025

camc314 marked this pull request as ready for review December 3, 2025 11:45

Copilot AI review requested due to automatic review settings December 3, 2025 11:45

camc314 assigned overlookmotel Dec 3, 2025

Copilot started reviewing on behalf of camc314 December 3, 2025 11:45 View session

This was referenced Dec 3, 2025

feat(semantic): expose get_comment_at method #16439

Merged

fix(linter/unicorn): fix ASI hazard in prefer-spread rule fixer #16440

Merged

Copilot finished reviewing on behalf of camc314 December 3, 2025 11:47

Copilot AI reviewed Dec 3, 2025

View reviewed changes

crates/oxc_ast/src/trivia.rs Outdated Show resolved Hide resolved

crates/oxc_ast/src/trivia.rs Outdated Show resolved Hide resolved

crates/oxc_ast/src/trivia.rs Outdated Show resolved Hide resolved

crates/oxc_ast/src/trivia.rs Show resolved Hide resolved

camc314 force-pushed the c/12-03-feat_ast_add_get_comment_at_function_for_efficient_comment_span_lookup branch 2 times, most recently from 01f85ab to 9517f01 Compare December 3, 2025 13:27

overlookmotel approved these changes Dec 3, 2025

View reviewed changes

overlookmotel assigned camc314 and unassigned overlookmotel Dec 3, 2025

camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2025

feat(ast): add get_comment_at to lookup a comment by span (#16438)

3981e7a

🤖 generated with help from Claude Opus 4.5

graphite-app bot force-pushed the c/12-03-feat_ast_add_get_comment_at_function_for_efficient_comment_span_lookup branch from 9517f01 to 3981e7a Compare December 3, 2025 13:49

graphite-app bot merged commit 3981e7a into main Dec 3, 2025
20 checks passed

graphite-app bot deleted the c/12-03-feat_ast_add_get_comment_at_function_for_efficient_comment_span_lookup branch December 3, 2025 13:56

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 3, 2025

graphite-app bot pushed a commit that referenced this pull request Dec 3, 2025

feat(semantic): expose get_comment_at method (#16439)

8c10694

This just exposes the method introduced into `oxc_ast` in #16438 🤖 generated with help from Claude Opus 4.5

Boshen mentioned this pull request Dec 8, 2025

release(crates): oxc v0.102.0 #16595

Merged

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025

feat(ast): add get_comment_at to lookup a comment by span (oxc-projec…

16b97f6

…t#16438) 🤖 generated with help from Claude Opus 4.5

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025

feat(semantic): expose get_comment_at method (oxc-project#16439)

8f4b336

This just exposes the method introduced into `oxc_ast` in oxc-project#16438 🤖 generated with help from Claude Opus 4.5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ast): add get_comment_at to lookup a comment by span#16438

feat(ast): add get_comment_at to lookup a comment by span#16438
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-feat_ast_add_get_comment_at_function_for_efficient_comment_span_lookup

camc314 commented Dec 3, 2025 •

edited

Loading

Uh oh!

camc314 commented Dec 3, 2025 •

edited

Loading

Uh oh!

camc314 commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

overlookmotel left a comment

Uh oh!

camc314 commented Dec 3, 2025 •

edited by graphite-app bot

Loading

Uh oh!

camc314 commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

camc314 commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #16438 will not alter performance

Summary

Footnotes

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

camc314 commented Dec 3, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

camc314 commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Dec 3, 2025 •

edited

Loading

camc314 commented Dec 3, 2025 •

edited

Loading

codspeed-hq bot commented Dec 3, 2025 •

edited

Loading

camc314 commented Dec 3, 2025 •

edited by graphite-app bot

Loading