feat(parser): add TS1174 error for classes extending multiple base classes by sapphi-red · Pull Request #15993 · oxc-project/oxc

sapphi-red · 2025-11-23T16:51:56Z

Added TS1174 error check.

sapphi-red · 2025-11-23T16:52:11Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-11-23T16:57:25Z

CodSpeed Performance Report

Merging #15993 will not alter performance

_{Comparing 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes (7a2afee) with main (5c62c16)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

No successful run was found on main (7a2afee) during the generation of this report, so 5c62c16 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Boshen · 2025-11-24T05:53:16Z

Merge activity

Nov 24, 5:53 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 6, 8:34 AM UTC: Boshen added this pull request to the Graphite merge queue.
Dec 6, 8:37 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
Dec 7, 7:35 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Dec 7, 7:41 AM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

This PR implements TypeScript error TS1174, which detects and reports when a class attempts to extend multiple base classes—a syntax error in TypeScript since classes can only extend a single class (multiple inheritance is not allowed).

Key changes:

Added diagnostic function classes_can_only_extend_single_class with appropriate error message and help text
Modified class parsing logic to emit TS1174 errors for each additional base class beyond the first
Updated test snapshots showing 3 previously failing negative tests now pass (1482→1485 passed)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_parser/src/diagnostics.rs	Added `classes_can_only_extend_single_class` diagnostic function for TS1174 error with helpful guidance
crates/oxc_parser/src/js/class.rs	Added logic to iterate through extra extends clauses and emit TS1174 error for each
tasks/coverage/snapshots/parser_typescript.snap	Updated test results showing 3 additional negative tests now correctly detect the multiple inheritance error

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…asses (#15993) Added TS1174 error check.

### 💥 BREAKING CHANGES - 083fea9 napi/parser: [**BREAKING**] Represent empty optional fields on JS side as `null` (#16411) (overlookmotel) ### 🚀 Features - 7a2afee parser: Add TS1174 error for classes extending multiple base classes (#15993) (sapphi-red) - da87812 semantic: Add TS2309 error for export assignment with other exports (#15992) (sapphi-red) - d6d2bcd minifier: Remove unused function calls that are marked by `manual_pure_functions` (#16534) (sapphi-red) - c90f053 minifier: Support `.` separated values for `compress.treeshake.manualPureFunctions` (#16529) (sapphi-red) - a607cc4 codegen: Preserve comments between CatchClause's param and body (#16167) (copilot-swe-agent) - 8c10694 semantic: Expose get_comment_at method (#16439) (camc314) - 3981e7a ast: Add get_comment_at to lookup a comment by span (#16438) (camc314) ### 🐛 Bug Fixes - 699406a napi/parser: Move `ExportEntry::module_request` field to first (#16412) (overlookmotel) - 12bd794 napi/parser: Move `ExportEntry::module_request` field to last (#16403) (overlookmotel) ### ⚡ Performance - 790beeb napi/parser: Do not remove extraneous options on JS side (#16447) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

…asses (oxc-project#15993) Added TS1174 error check.

### 💥 BREAKING CHANGES - 083fea9 napi/parser: [**BREAKING**] Represent empty optional fields on JS side as `null` (oxc-project#16411) (overlookmotel) ### 🚀 Features - 7a2afee parser: Add TS1174 error for classes extending multiple base classes (oxc-project#15993) (sapphi-red) - da87812 semantic: Add TS2309 error for export assignment with other exports (oxc-project#15992) (sapphi-red) - d6d2bcd minifier: Remove unused function calls that are marked by `manual_pure_functions` (oxc-project#16534) (sapphi-red) - c90f053 minifier: Support `.` separated values for `compress.treeshake.manualPureFunctions` (oxc-project#16529) (sapphi-red) - a607cc4 codegen: Preserve comments between CatchClause's param and body (oxc-project#16167) (copilot-swe-agent) - 8c10694 semantic: Expose get_comment_at method (oxc-project#16439) (camc314) - 3981e7a ast: Add get_comment_at to lookup a comment by span (oxc-project#16438) (camc314) ### 🐛 Bug Fixes - 699406a napi/parser: Move `ExportEntry::module_request` field to first (oxc-project#16412) (overlookmotel) - 12bd794 napi/parser: Move `ExportEntry::module_request` field to last (oxc-project#16403) (overlookmotel) ### ⚡ Performance - 790beeb napi/parser: Do not remove extraneous options on JS side (oxc-project#16447) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Nov 23, 2025

sapphi-red mentioned this pull request Nov 23, 2025

feat(semantic): add TS2309 error for export assignment with other exports #15992

Merged

sapphi-red marked this pull request as ready for review November 23, 2025 17:08

sapphi-red requested a review from Boshen November 23, 2025 17:09

sapphi-red assigned Boshen Nov 23, 2025

Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025

graphite-app bot changed the base branch from 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports to graphite-base/15993 November 25, 2025 06:32

sapphi-red force-pushed the graphite-base/15993 branch from 3748cbb to f317b33 Compare November 26, 2025 12:33

sapphi-red force-pushed the 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes branch from 3eb5101 to 637d155 Compare November 26, 2025 12:33

sapphi-red changed the base branch from graphite-base/15993 to 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports November 26, 2025 12:33

sapphi-red force-pushed the 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports branch from f317b33 to 307b964 Compare December 6, 2025 08:23

sapphi-red force-pushed the 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes branch from 637d155 to aa41ca5 Compare December 6, 2025 08:23

graphite-app bot changed the base branch from 11-20-feat_parser_add_ts2309_error_for_export_assignment_with_other_exports to graphite-base/15993 December 6, 2025 08:30

graphite-app bot changed the base branch from graphite-base/15993 to main December 6, 2025 08:36

graphite-app bot requested a review from Dunqing as a code owner December 6, 2025 08:36

github-actions bot added the A-semantic Area - Semantic label Dec 6, 2025

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 6, 2025

sapphi-red force-pushed the 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes branch from aa41ca5 to ee5b15f Compare December 7, 2025 06:42

Copilot AI review requested due to automatic review settings December 7, 2025 06:42

Copilot started reviewing on behalf of sapphi-red December 7, 2025 06:42 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

feat(parser): add TS1174 error for classes extending multiple base cl…

7a2afee

…asses (#15993) Added TS1174 error check.

graphite-app bot force-pushed the 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes branch from ee5b15f to 7a2afee Compare December 7, 2025 07:35

graphite-app bot merged commit 7a2afee into main Dec 7, 2025
28 checks passed

graphite-app bot deleted the 11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes branch December 7, 2025 07:41

Boshen mentioned this pull request Dec 8, 2025

release(crates): oxc v0.102.0 #16595

Merged

taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025

feat(parser): add TS1174 error for classes extending multiple base cl…

1a9e205

…asses (oxc-project#15993) Added TS1174 error check.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(parser): add TS1174 error for classes extending multiple base classes#15993

feat(parser): add TS1174 error for classes extending multiple base classes#15993
graphite-app[bot] merged 1 commit intomainfrom
11-20-feat_parser_add_ts1174_error_for_classes_extending_multiple_base_classes

sapphi-red commented Nov 23, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Nov 23, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

Boshen commented Nov 24, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sapphi-red commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15993 will not alter performance

Summary

Footnotes

Uh oh!

Boshen commented Nov 24, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sapphi-red commented Nov 23, 2025 •

edited

Loading

sapphi-red commented Nov 23, 2025 •

edited

Loading

codspeed-hq bot commented Nov 23, 2025 •

edited

Loading

Boshen commented Nov 24, 2025 •

edited by graphite-app bot

Loading