Skip to content

fix(semantic): add TS error code to constructor implementation missing diagnostic#16517

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic
Dec 8, 2025
Merged

fix(semantic): add TS error code to constructor implementation missing diagnostic#16517
graphite-app[bot] merged 1 commit intomainfrom
c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 4, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review December 4, 2025 21:59
@camc314 camc314 requested a review from Dunqing as a code owner December 4, 2025 21:59
Copilot AI review requested due to automatic review settings December 4, 2025 21:59
Copy link
Contributor Author

camc314 commented Dec 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the TypeScript error code TS(2390) to the "Constructor implementation is missing" diagnostic message, improving alignment with TypeScript's official error reporting format.

  • Converts the diagnostic function from using OxcDiagnostic::error() to ts_error("2390", ...) helper
  • Updates all 8 snapshot test occurrences to reflect the new error message format with the TS error code prefix

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_semantic/src/checker/typescript.rs Modified constructor_implementation_missing function to use ts_error helper with error code "2390"
tasks/coverage/snapshots/parser_typescript.snap Updated all 8 test snapshots to show the new error message format: × TS(2390): Constructor implementation is missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #16517 will not alter performance

Comparing c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic (82848f3) with main (cfdfe7d)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 8, 2025

Merge activity

  • Dec 8, 9:11 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Dec 8, 9:11 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 8, 9:11 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 8, 9:31 AM UTC: graphite-app added this pull request to the Graphite merge queue.
  • Dec 8, 9:32 AM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Dec 8, 12:10 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 8, 12:10 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 8, 12:17 PM UTC: Merged by the Graphite merge queue.

@camc314 camc314 force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic branch from 82848f3 to b4023b4 Compare December 8, 2025 09:15
graphite-app bot pushed a commit that referenced this pull request Dec 8, 2025
@graphite-app graphite-app bot force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic branch from b4023b4 to 45ee0e0 Compare December 8, 2025 09:26
@camc314 camc314 marked this pull request as draft December 8, 2025 09:31
@camc314
Copy link
Contributor Author

camc314 commented Dec 8, 2025

holding to merge until after the release

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@camc314 camc314 marked this pull request as ready for review December 8, 2025 12:10
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@graphite-app graphite-app bot force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic branch from 45ee0e0 to e4fad5e Compare December 8, 2025 12:11
@graphite-app graphite-app bot merged commit e4fad5e into main Dec 8, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic branch December 8, 2025 12:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants