fix(semantic): add TS error code to constructor implementation missing diagnostic#16517
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR adds the TypeScript error code TS(2390) to the "Constructor implementation is missing" diagnostic message, improving alignment with TypeScript's official error reporting format.
- Converts the diagnostic function from using
OxcDiagnostic::error()tots_error("2390", ...)helper - Updates all 8 snapshot test occurrences to reflect the new error message format with the TS error code prefix
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_semantic/src/checker/typescript.rs | Modified constructor_implementation_missing function to use ts_error helper with error code "2390" |
| tasks/coverage/snapshots/parser_typescript.snap | Updated all 8 test snapshots to show the new error message format: × TS(2390): Constructor implementation is missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #16517 will not alter performanceComparing Summary
Footnotes
|
Merge activity
|
82848f3 to
b4023b4
Compare
b4023b4 to
45ee0e0
Compare
|
holding to merge until after the release |
45ee0e0 to
e4fad5e
Compare

No description provided.