Skip to content

fix(semantic): add TS error code to constructor implementation missing diagnostic #16517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 8, 2025
Merged

fix(semantic): add TS error code to constructor implementation missing diagnostic #16517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_semantic/src/checker/typescript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ fn abstract_elem_in_concrete_class(is_property: bool, span: Span) -> OxcDiagnost
}

fn constructor_implementation_missing(span: Span) -> OxcDiagnostic {
OxcDiagnostic::error("Constructor implementation is missing.").with_label(span)
ts_error("2390", "Constructor implementation is missing.").with_label(span)
}

fn function_implementation_missing(span: Span) -> OxcDiagnostic {
Expand Down
16 changes: 8 additions & 8 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,7 +2337,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
╰────
help: No modifiers are allowed here.

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/compiler/ClassDeclaration10.ts:2:4]
1 │ class C {
2 │ constructor();
Expand All @@ -2353,7 +2353,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
4 │ }
╰────

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/compiler/ClassDeclaration11.ts:2:4]
1 │ class C {
2 │ constructor();
Expand All @@ -2377,7 +2377,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
3 │ constructor();
╰────

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/compiler/ClassDeclaration14.ts:3:4]
2 │ foo();
3 │ constructor();
Expand Down Expand Up @@ -2450,7 +2450,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
3 │
╰────

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/compiler/ClassDeclaration8.ts:2:3]
1 │ class C {
2 │ constructor();
Expand Down Expand Up @@ -21042,7 +21042,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
2 │ }
╰────

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/ClassDeclarations/parserClassDeclaration10.ts:2:4]
1 │ class C {
2 │ constructor();
Expand All @@ -21058,7 +21058,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
4 │ }
╰────

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/ClassDeclarations/parserClassDeclaration11.ts:2:4]
1 │ class C {
2 │ constructor();
Expand All @@ -21082,7 +21082,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
3 │ constructor();
╰────

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/ClassDeclarations/parserClassDeclaration14.ts:3:4]
2 │ foo();
3 │ constructor();
Expand Down Expand Up @@ -21178,7 +21178,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
╰────
help: Remove the extra base class or use interfaces for multiple inheritance

× Constructor implementation is missing.
× TS(2390): Constructor implementation is missing.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/ClassDeclarations/parserClassDeclaration8.ts:2:3]
1 │ class C {
2 │ constructor();
Expand Down
Loading