Skip to content

fix(semantic): add TS error code to function implementation missing diagnostic#16518

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic
Dec 8, 2025
Merged

fix(semantic): add TS error code to function implementation missing diagnostic#16518
graphite-app[bot] merged 1 commit intomainfrom
c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 4, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review December 4, 2025 21:59
@camc314 camc314 requested a review from Dunqing as a code owner December 4, 2025 21:59
@github-actions github-actions bot added A-semantic Area - Semantic C-bug Category - Bug labels Dec 4, 2025
Copy link
Contributor Author

camc314 commented Dec 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #16518 will degrade performances by 3.61%

Comparing c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic (8c09825) with c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic (82848f3)

Summary

❌ 3 regressions
✅ 39 untouched
⏩ 3 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation formatter[next.ts] 2.7 ms 2.8 ms -3.23%
Simulation formatter[Search.tsx] 1.9 ms 1.9 ms -3.06%
Simulation formatter[types.ts] 14.7 ms 15.3 ms -3.61%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copy link
Member

Dunqing commented Dec 8, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic to graphite-base/16518 December 8, 2025 09:11
@camc314 camc314 force-pushed the graphite-base/16518 branch from 82848f3 to b4023b4 Compare December 8, 2025 09:15
@camc314 camc314 force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic branch from 8c09825 to 669e198 Compare December 8, 2025 09:15
@camc314 camc314 changed the base branch from graphite-base/16518 to c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic December 8, 2025 09:15
@graphite-app graphite-app bot force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic branch from b4023b4 to 45ee0e0 Compare December 8, 2025 09:26
graphite-app bot pushed a commit that referenced this pull request Dec 8, 2025
@graphite-app graphite-app bot force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic branch from 669e198 to de13bd6 Compare December 8, 2025 09:27
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@graphite-app graphite-app bot force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic branch from 45ee0e0 to e4fad5e Compare December 8, 2025 12:11
@graphite-app graphite-app bot force-pushed the c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic branch from de13bd6 to 75d489a Compare December 8, 2025 12:12
Base automatically changed from c/12-04-fix_semantic_add_ts_error_code_to_constructor_implementation_missing_diagnostic to main December 8, 2025 12:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@graphite-app graphite-app bot merged commit 75d489a into main Dec 8, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/12-04-fix_semantic_add_ts_error_code_to_function_implementation_missing_diagnostic branch December 8, 2025 12:18
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants