Skip to content

Comments

refactor(formatter): remove BufferSnapshot#16476

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-04-refactor_formatter_remove_buffersnapshot
Dec 4, 2025
Merged

refactor(formatter): remove BufferSnapshot#16476
graphite-app[bot] merged 1 commit intomainfrom
12-04-refactor_formatter_remove_buffersnapshot

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 4, 2025

After #16437, there are no usages of BufferSnapshot.

Copy link
Member Author

Dunqing commented Dec 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #16476 will not alter performance

Comparing 12-04-refactor_formatter_remove_buffersnapshot (f67fddb) with 12-04-feat_formatter_add_debug_assertion_to_ensure_that_there_is_no_empty_content_is_passed_in (9ae94bb)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2025

Merge activity

After #16437, there are no usages of `BufferSnapshot`.
@graphite-app graphite-app bot force-pushed the 12-04-feat_formatter_add_debug_assertion_to_ensure_that_there_is_no_empty_content_is_passed_in branch from 9ae94bb to 80e6999 Compare December 4, 2025 07:33
@graphite-app graphite-app bot force-pushed the 12-04-refactor_formatter_remove_buffersnapshot branch from f67fddb to 1042773 Compare December 4, 2025 07:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 4, 2025
Base automatically changed from 12-04-feat_formatter_add_debug_assertion_to_ensure_that_there_is_no_empty_content_is_passed_in to main December 4, 2025 07:40
@graphite-app graphite-app bot merged commit 1042773 into main Dec 4, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-04-refactor_formatter_remove_buffersnapshot branch December 4, 2025 07:42
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants