Skip to content

Comments

refactor(formatter): avoid formatting empty vec AST#16436

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-03-refactor_formatter_avoid_formatting_empty_vec_ast
Dec 4, 2025
Merged

refactor(formatter): avoid formatting empty vec AST#16436
graphite-app[bot] merged 1 commit intomainfrom
12-03-refactor_formatter_avoid_formatting_empty_vec_ast

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 3, 2025

Prepare for #16437.

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 3, 2025
Copy link
Member Author

Dunqing commented Dec 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #16436 will not alter performance

Comparing 12-03-refactor_formatter_avoid_formatting_empty_vec_ast (30026b2) with 12-03-perf_formatter_early_return_when_no_comments_need_to_be_printed (4ef403e)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-03-perf_formatter_early_return_when_no_comments_need_to_be_printed branch from 4ef403e to 201c98f Compare December 4, 2025 07:31
@graphite-app graphite-app bot force-pushed the 12-03-refactor_formatter_avoid_formatting_empty_vec_ast branch from 30026b2 to 6296b18 Compare December 4, 2025 07:31
Base automatically changed from 12-03-perf_formatter_early_return_when_no_comments_need_to_be_printed to main December 4, 2025 07:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 4, 2025
@graphite-app graphite-app bot merged commit 6296b18 into main Dec 4, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-03-refactor_formatter_avoid_formatting_empty_vec_ast branch December 4, 2025 07:38
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants