build(linter/plugins): simplify TSDown config#15948
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 21, 2025
Merged
Conversation
This was referenced Nov 21, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
overlookmotel
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
5d340df to
ba7b9b6
Compare
overlookmotel
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
75bcbdb to
5633be4
Compare
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
ba7b9b6 to
dacaaf2
Compare
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
5633be4 to
f1a8cbc
Compare
graphite-app
bot
changed the base branch from
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
to
graphite-base/15948
camc314
reviewed
Nov 21, 2025
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
f1a8cbc to
cda76ed
Compare
graphite-app
bot
force-pushed
the
graphite-base/15948
branch
from
dacaaf2 to
152e5de
Compare
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
cda76ed to
ad43f29
Compare
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
ad43f29 to
2a9ead3
Compare
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
2a9ead3 to
72da02e
Compare
overlookmotel
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
72da02e to
d6d14a3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the TSDown build configuration for the oxlint package by consolidating two separate build configurations into a single build with multiple entry points. This change is made possible by a previous fix (#15946) that resolved issues with assert* functions ending up in shared chunks.
Key changes:
- Merged separate
cli.tsandindex.tsbuilds into a single config with two entry points - Added post-build cleanup to remove unwanted
cli.d.tsdeclaration files - Updated debug config generation to use object spread from the main config
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxlint/tsdown.config.ts | Consolidated two separate TSDown configs into one with multiple entry points; simplified debug config creation |
| apps/oxlint/scripts/build.ts | Added rmSync import and logic to delete generated cli.d.ts files from both dist and debug directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
d6d14a3 to
9c002a1
Compare
Member
Author
Merge activity
|
#15946 means we can now simplify the TSDown build config. Previously we had to have 2 separate builds for `index.ts` and `cli.ts`, to avoid `assert*` functions ending up in a shared chunk, and not getting removed by minifier. Now that problem is solved, so we can switch to a single build with 2 entry points. TSDown does create a small extra chunk for its `__toESM` and `__commonJSMin` functions, but I think that's fine. Annoyingly it doesn't seem to be possible to tell TSDown to generate `.d.ts` files only for the `index.js` chunk, so have to delete this pointless files in build script. The point of all this is that `RuleTester` needs to use a ton of code from `plugins.ts`, and we wouldn't want all that code duplicated in both `index` and `plugins` chunks (especially once we're bundling TS-ESlint's parser #15861). Now that code will be shared between the two entry points in a shared chunk, not duplicated.
graphite-app
bot
force-pushed
the
11-21-build_linter_plugins_simplify_tsdown_config
branch
from
9c002a1 to
8b3fd1c
Compare
graphite-app
bot
deleted the
11-21-build_linter_plugins_simplify_tsdown_config
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
oxc-project#15946 means we can now simplify the TSDown build config. Previously we had to have 2 separate builds for `index.ts` and `cli.ts`, to avoid `assert*` functions ending up in a shared chunk, and not getting removed by minifier. Now that problem is solved, so we can switch to a single build with 2 entry points. TSDown does create a small extra chunk for its `__toESM` and `__commonJSMin` functions, but I think that's fine. Annoyingly it doesn't seem to be possible to tell TSDown to generate `.d.ts` files only for the `index.js` chunk, so have to delete this pointless files in build script. The point of all this is that `RuleTester` needs to use a ton of code from `plugins.ts`, and we wouldn't want all that code duplicated in both `index` and `plugins` chunks (especially once we're bundling TS-ESlint's parser oxc-project#15861). Now that code will be shared between the two entry points in a shared chunk, not duplicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15946 means we can now simplify the TSDown build config.
Previously we had to have 2 separate builds for
index.tsandcli.ts, to avoidassert*functions ending up in a shared chunk, and not getting removed by minifier. Now that problem is solved, so we can switch to a single build with 2 entry points.TSDown does create a small extra chunk for its
__toESMand__commonJSMinfunctions, but I think that's fine.Annoyingly it doesn't seem to be possible to tell TSDown to generate
.d.tsfiles only for theindex.jschunk, so have to delete this pointless files in build script.The point of all this is that
RuleTesterneeds to use a ton of code fromplugins.ts, and we wouldn't want all that code duplicated in bothindexandpluginschunks (especially once we're bundling TS-ESlint's parser #15861). Now that code will be shared between the two entry points in a shared chunk, not duplicated.