Skip to content

build(linter/plugins): simplify TSDown config #15948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 21, 2025
Merged

build(linter/plugins): simplify TSDown config #15948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/oxlint/scripts/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { execSync } from 'node:child_process';
import { copyFileSync, readdirSync, readFileSync, writeFileSync } from 'node:fs';
import { copyFileSync, readdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
import { join } from 'node:path';

const oxlintDirPath = join(import.meta.dirname, '..'),
Expand All @@ -21,6 +21,11 @@ writeFileSync(bindingsPath, bindingsJs);
console.log('Building with tsdown...');
execSync('pnpm tsdown', { stdio: 'inherit', cwd: oxlintDirPath });

// Delete `cli.d.ts`
console.log('Deleting cli.d.ts...');
rmSync(join(distDirPath, 'cli.d.ts'));
rmSync(join(debugDirPath, 'cli.d.ts'));

// Copy native `.node` files from `src-js`
console.log('Copying `.node` files...');
for (const filename of readdirSync(srcDirPath)) {
Expand Down
30 changes: 8 additions & 22 deletions apps/oxlint/tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import { join } from 'node:path';
import { defineConfig } from 'tsdown';

import type { UserConfig } from 'tsdown';
import type { Plugin } from 'rolldown';

const ASSERTS_PATH = join(import.meta.dirname, 'src-js/utils/asserts.ts');

const replaceAssertsPlugin = createReplaceAssertsPlugin();
const plugins = [replaceAssertsPlugin];

const commonConfig: UserConfig = {
const config = defineConfig({
entry: ['src-js/cli.ts', 'src-js/index.ts'],
format: 'esm',
platform: 'node',
target: 'node20',
Expand All @@ -30,39 +30,25 @@ const commonConfig: UserConfig = {
mangle: false,
codegen: { removeWhitespace: false },
},
dts: { resolve: true },
attw: true,
define: { DEBUG: 'false' },
plugins,
inputOptions: {
// For `replaceAssertsPlugin`
experimental: { nativeMagicString: true },
},
};

// Only generate `.d.ts` file for main export, not for CLI
const configs = defineConfig([
{
entry: 'src-js/cli.ts',
...commonConfig,
dts: false,
},
{
entry: 'src-js/index.ts',
...commonConfig,
dts: { resolve: true },
attw: true,
},
]);
});

// Create separate debug build with debug assertions enabled
const debugConfigs = configs.map((config) => ({
const debugConfig = defineConfig({
...config,
outDir: 'debug',
define: { DEBUG: 'true' },
plugins: plugins.filter((plugin) => plugin !== replaceAssertsPlugin),
}));
configs.push(...debugConfigs);
});

export default configs;
export default [config, debugConfig];

/**
* Create a plugin to remove imports of `assert*` functions from `src-js/utils/asserts.ts`,
Expand Down
Loading