refactor(linter/plugins): replace ! with assertIsNonNull#15947
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 21, 2025
Merged
Conversation
github-actions
bot
added
A-linter
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
11-21-refactor_linter_plugins_ensure_debug_assertions_always_shaken_out_of_release_build
branch
from
6c71108 to
e0f471f
Compare
overlookmotel
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
5d340df to
ba7b9b6
Compare
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_ensure_debug_assertions_always_shaken_out_of_release_build
branch
2 times, most recently
from
df631d3 to
13bc9e2
Compare
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
ba7b9b6 to
dacaaf2
Compare
camc314
approved these changes
Nov 21, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_ensure_debug_assertions_always_shaken_out_of_release_build
branch
from
13bc9e2 to
4ad085c
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
After #15946, we're now free to use `assertIsNonNull` in `cli.ts` without breaking dead code removal. So use it instead of unchecked `!` assertions. In debug build it becomes a real runtime assertion.
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
dacaaf2 to
441c922
Compare
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_ensure_debug_assertions_always_shaken_out_of_release_build
branch
from
4ad085c to
152e5de
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
After #15946, we're now free to use `assertIsNonNull` in `cli.ts` without breaking dead code removal. So use it instead of unchecked `!` assertions. In debug build it becomes a real runtime assertion.
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
441c922 to
de940a2
Compare
Base automatically changed from
11-21-refactor_linter_plugins_ensure_debug_assertions_always_shaken_out_of_release_build
to
main
November 21, 2025 15:05
After #15946, we're now free to use `assertIsNonNull` in `cli.ts` without breaking dead code removal. So use it instead of unchecked `!` assertions. In debug build it becomes a real runtime assertion.
graphite-app
bot
force-pushed
the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
from
de940a2 to
0ade564
Compare
graphite-app
bot
deleted the
11-21-refactor_linter_plugins_replace_with_assertisnonnull_
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ject#15947) After oxc-project#15946, we're now free to use `assertIsNonNull` in `cli.ts` without breaking dead code removal. So use it instead of unchecked `!` assertions. In debug build it becomes a real runtime assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #15946, we're now free to use
assertIsNonNullincli.tswithout breaking dead code removal. So use it instead of unchecked!assertions. In debug build it becomes a real runtime assertion.