Skip to content

refactor(linter/plugins): replace ! with assertIsNonNull #15947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 21, 2025
Merged

refactor(linter/plugins): replace ! with assertIsNonNull #15947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/oxlint/src-js/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { lint } from './bindings.js';
import { assertIsNonNull } from './utils/asserts.js';

// Lazy-loaded JS plugin-related functions.
// Using `typeof wrapper` here makes TS check that the function signatures of `loadPlugin` and `loadPluginWrapper`
Expand All @@ -24,7 +25,8 @@ function loadPluginWrapper(path: string, packageName: string | null): Promise<st
return loadPlugin(path, packageName);
});
}
return loadPlugin!(path, packageName);
assertIsNonNull(loadPlugin);
return loadPlugin(path, packageName);
}

/**
Expand All @@ -48,7 +50,8 @@ function lintFileWrapper(
): string {
// `lintFileWrapper` is never called without `loadPluginWrapper` being called first,
// so `lintFile` must be defined here
return lintFile!(filePath, bufferId, buffer, ruleIds, settingsJSON);
assertIsNonNull(lintFile);
return lintFile(filePath, bufferId, buffer, ruleIds, settingsJSON);
}

// Get command line arguments, skipping first 2 (node binary and script path)
Expand Down
Loading