Skip to content

style(oxlint/plugins): format test fixtures#15600

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-11-style_oxlint_plugins_format_test_fixtures
Nov 11, 2025
Merged

style(oxlint/plugins): format test fixtures#15600
graphite-app[bot] merged 1 commit intomainfrom
11-11-style_oxlint_plugins_format_test_fixtures

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 11, 2025

Format oxlint test fixtures. The directory fixtures contains not just the fixtures themselves, but also Oxlint plugins, which should be formatted.

Skip 2 specific test fixture files which must not be formatted to maintain correctness of the tests.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 11, 2025
Copy link
Member Author

overlookmotel commented Nov 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 11, 2025 15:47
Copilot AI review requested due to automatic review settings November 11, 2025 15:47
@overlookmotel overlookmotel force-pushed the 11-11-style_oxlint_plugins_format_test_fixtures branch from 1340328 to 65e1478 Compare November 11, 2025 15:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates formatting for Oxlint plugin test fixtures by enabling formatting for apps/oxlint/test/fixtures directory while maintaining exclusions for specific test files that depend on unformatted code for correctness.

Key Changes:

  • Updated oxfmtrc.jsonc to selectively format oxlint test fixtures while excluding other fixture directories and two specific test cases
  • Applied consistent formatting to 14 plugin test files including arrow function parameters, string concatenation, and object properties
  • Updated test snapshots to match formatted test files

Reviewed Changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
oxfmtrc.jsonc Refined ignore patterns to allow formatting of oxlint plugins while excluding other fixtures and specific test files
apps/oxlint/test/fixtures/utf16_offsets/plugin.ts Reformatted multi-line string concatenations
apps/oxlint/test/fixtures/sourceCode_scope_methods/plugin.ts Added parentheses to arrow function parameters
apps/oxlint/test/fixtures/sourceCode_late_access_after_only/plugin.ts Reformatted multi-line message strings
apps/oxlint/test/fixtures/sourceCode_late_access/plugin.ts Reformatted multi-line string concatenations across multiple functions
apps/oxlint/test/fixtures/sourceCode/plugin.ts Reformatted multi-line string concatenations in create and createOnce rules
apps/oxlint/test/fixtures/settings/plugin.ts Added parentheses to arrow function parameter
apps/oxlint/test/fixtures/selector/plugin.ts Reformatted multi-line map/join chain for better readability
apps/oxlint/test/fixtures/selector/output.snap.md Updated snapshot to reflect formatted test file
apps/oxlint/test/fixtures/selector/files/index.js Removed unnecessary parentheses from arrow function expression
apps/oxlint/test/fixtures/scope_manager/plugin.ts Added parentheses to arrow function parameters and reformatted multi-line strings
apps/oxlint/test/fixtures/parent/plugin.ts Reformatted multi-line expressions and improved TypeScript error suppression comment
apps/oxlint/test/fixtures/isSpaceBetween/plugin.ts Fixed indentation in context.report block
apps/oxlint/test/fixtures/fixes/plugin.ts Removed unnecessary quotes from object property name
apps/oxlint/test/fixtures/estree/plugin.ts Reformatted multi-line strings and added parentheses to arrow function parameters
apps/oxlint/test/fixtures/comments/plugin.ts Reformatted multi-line string concatenations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel self-assigned this Nov 11, 2025
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins 0-merge Merge with Graphite Merge Queue and removed A-linter Area - Linter labels Nov 11, 2025
Copy link
Member Author

overlookmotel commented Nov 11, 2025

Merge activity

Format `oxlint` test fixtures. The directory `fixtures` contains not just the fixtures themselves, but also Oxlint plugins, which should be formatted.

Skip 2 specific test fixture files which must not be formatted to maintain correctness of the tests.
@graphite-app graphite-app bot force-pushed the 11-11-style_oxlint_plugins_format_test_fixtures branch from 65e1478 to aee9be1 Compare November 11, 2025 15:56
@github-actions github-actions bot added the A-linter Area - Linter label Nov 11, 2025
@graphite-app graphite-app bot merged commit aee9be1 into main Nov 11, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-11-style_oxlint_plugins_format_test_fixtures branch November 11, 2025 16:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
Follow-on after #15593 and #15600. Use `// prettier-ignore` comments in test fixture files to prevent them being formatted, where formatting would break the test.
graphite-app bot pushed a commit that referenced this pull request Nov 13, 2025
…res (#15601)

Update `oxfmt` config so it formats `apps/oxlint/test/fixtures`.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.
graphite-app bot pushed a commit that referenced this pull request Nov 13, 2025
…res (#15601)

Update `oxfmt` config so it formats `apps/oxlint/test/fixtures`.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants