Skip to content

Comments

test(linter/plugins): prevent test fixture getting formatted#15674

Merged
overlookmotel merged 1 commit intomainfrom
11-13-test_linter_plugins_prevent_test_fixture_getting_formatted
Nov 13, 2025
Merged

test(linter/plugins): prevent test fixture getting formatted#15674
overlookmotel merged 1 commit intomainfrom
11-13-test_linter_plugins_prevent_test_fixture_getting_formatted

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 13, 2025 •
edited
Loading

Add // prettier-ignore comment to test fixture, to prevent it getting formatted once #15601 is merged.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Nov 13, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Nov 13, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2025 14:36
Copilot AI review requested due to automatic review settings November 13, 2025 14:36
@overlookmotel overlookmotel added A-linter-plugins Area - Linter JS plugins and removed A-linter Area - Linter labels Nov 13, 2025
@overlookmotel overlookmotel self-assigned this Nov 13, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 13, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 13, 2:37 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 2:50 PM UTC: overlookmotel added this pull request to the Graphite merge queue.

Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a // prettier-ignore comment to a JSX test fixture to prevent it from being reformatted when PR #15601 is merged. The test fixture is part of the isSpaceBetween test suite for oxlint's JS plugin functionality.

Key Changes:

  • Added // prettier-ignore comment before the <Qux> JSX element
  • Reformatted the JSX element from multi-line to compact format
  • Updated snapshot file to reflect the new test fixture output

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/oxlint/test/fixtures/isSpaceBetween/files/index.jsx Added // prettier-ignore comment and reformatted JSX element to compact format
apps/oxlint/test/fixtures/isSpaceBetween/output.snap.md Updated snapshot to reflect the changes in the test fixture file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel mentioned this pull request Nov 13, 2025
Merged
@overlookmotel overlookmotel marked this pull request as draft November 13, 2025 14:47
@overlookmotel overlookmotel marked this pull request as ready for review November 13, 2025 14:49
@overlookmotel
Copy link
Member Author

overlookmotel commented Nov 13, 2025

Graphite has got stuck. Merging manually.

@overlookmotel overlookmotel merged commit c9e0951 into main Nov 13, 2025
26 checks passed
@overlookmotel overlookmotel deleted the 11-13-test_linter_plugins_prevent_test_fixture_getting_formatted branch November 13, 2025 15:09
graphite-app bot pushed a commit that referenced this pull request Nov 13, 2025
@overlookmotel
style(linter/plugins): update oxfmt config to format oxlint fixtu…
709e4e4 
…res (#15601)

Update `oxfmt` config so it formats `apps/oxlint/test/fixtures`.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.
graphite-app bot pushed a commit that referenced this pull request Nov 13, 2025
@overlookmotel
style(linter/plugins): update oxfmt config to format oxlint fixtu…
6ce62c5 
…res (#15601)

Update `oxfmt` config so it formats `apps/oxlint/test/fixtures`.

Actual formatting changes were in PRs #15600 and #15674. This PR alters the config so all these files will continue to be formatted in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel