style(oxlint/plugins): update oxfmt config to only format plugins in oxlint fixtures#15862
style(oxlint/plugins): update oxfmt config to only format plugins in oxlint fixtures#15862lilnasy wants to merge 2 commits intooxc-project:mainfrom
oxfmt config to only format plugins in oxlint fixtures#15862Conversation
oxfmt config to only format plugins in oxlint fixtures
There was a problem hiding this comment.
Pull Request Overview
This PR refines the formatting configuration to prevent CI auto-formatting from breaking test assertions in fixture files. Previously, all files under apps/oxlint/test/fixtures/ were included for formatting; now only files specifically named plugin.ts are formatted.
Key Changes
- Modified the ignore pattern from including all fixture files to only including
plugin.tsfiles - This prevents test input files (which may intentionally contain linting errors) from being auto-formatted
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cae92b7 to
d7694c3
Compare
|
Personally, I like formatting everything that can be formatted. We can use Unless this is going to be a major ball-ache for token APIs? |
|
This doesn't uniquely affect token APIs. Edit: maybe I spoke too soon. I imagine there will be more cases like this: #15861 (comment). I was thrown off by the autofix CI autobreaking already written tests. I'll add |
|
I don't know what editor you use. I use VS Code, and have installed the Oxc VS Code extension, with "experimental format" and "format on save" options enabled. That's quite useful for this, as when editing fixture files, you see immediately if the file is going to get formatted in a way that you don't want, and it's obvious where to put the But Oxfmt is alpha, so completely understand if you don't want to use it. Prettier doesn't support a |
oxfmtconfig to formatoxlintfixtures #15601.