Skip to content

Comments

perf(language_server): start tools in parallel#15500

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-08-perf_language_server_execute_tools_in_parallel
Nov 9, 2025
Merged

perf(language_server): start tools in parallel#15500
graphite-app[bot] merged 1 commit intomainfrom
11-08-perf_language_server_execute_tools_in_parallel

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Nov 8, 2025

No description provided.

Copy link
Member Author

Sysix commented Nov 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes asynchronous operations in the language server worker by parallelizing tasks that don't have dependencies on each other. It uses tokio::join! to run independent operations concurrently.

  • Parallel initialization of linter and formatter in start_worker method
  • Parallel reading of linter and formatter patterns in init_watchers method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix changed the title perf(language_server): execute tools in parallel perf(language_server): start tools in parallel Nov 8, 2025
@Sysix Sysix force-pushed the 11-08-reactor_language_server_implement_tool_shutdown_trait_method branch from c38b086 to 2956e66 Compare November 8, 2025 19:43
@Sysix Sysix force-pushed the 11-08-perf_language_server_execute_tools_in_parallel branch from 2463284 to 40fc841 Compare November 8, 2025 19:43
@Sysix Sysix force-pushed the 11-08-reactor_language_server_implement_tool_shutdown_trait_method branch from 2956e66 to 2e22526 Compare November 8, 2025 19:44
@Sysix Sysix force-pushed the 11-08-perf_language_server_execute_tools_in_parallel branch from 40fc841 to c5c8a8d Compare November 8, 2025 19:44
@Sysix Sysix marked this pull request as ready for review November 8, 2025 19:47
@Sysix Sysix requested a review from camc314 as a code owner November 8, 2025 19:47
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 9, 2025
Copy link
Contributor

camc314 commented Nov 9, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 9, 2025
@Sysix Sysix force-pushed the 11-08-reactor_language_server_implement_tool_shutdown_trait_method branch from 2e22526 to 232076b Compare November 9, 2025 00:36
@Sysix Sysix force-pushed the 11-08-perf_language_server_execute_tools_in_parallel branch from c5c8a8d to 4abc114 Compare November 9, 2025 00:36
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Nov 9, 2025
@graphite-app graphite-app bot force-pushed the 11-08-reactor_language_server_implement_tool_shutdown_trait_method branch from 232076b to 77c5d30 Compare November 9, 2025 00:42
@graphite-app graphite-app bot force-pushed the 11-08-perf_language_server_execute_tools_in_parallel branch from 4abc114 to 25d577e Compare November 9, 2025 00:42
Base automatically changed from 11-08-reactor_language_server_implement_tool_shutdown_trait_method to main November 9, 2025 00:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 9, 2025
@graphite-app graphite-app bot merged commit 25d577e into main Nov 9, 2025
22 checks passed
@graphite-app graphite-app bot deleted the 11-08-perf_language_server_execute_tools_in_parallel branch November 9, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants