refactor(language_server): move restart to Tool::handle_watched_file_change trait method#15491
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 9, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
changed the base branch from
11-08-refactor_language_server_move_get_code_actions_or_commands_to_tool_trait
to
graphite-base/15491
Sysix
force-pushed
the
11-08-feat_language_server_handle_new_watch_patterns_when_watched_file_is_changed
branch
from
5e56e20 to
753e9df
Compare
Sysix
force-pushed
the
graphite-base/15491
branch
from
7f95bba to
79e6842
Compare
Sysix
force-pushed
the
11-08-feat_language_server_handle_new_watch_patterns_when_watched_file_is_changed
branch
from
753e9df to
cc637a8
Compare
Sysix
changed the title
Tool::handle_watched_file_change trait method
github-actions
bot
added
the
C-cleanup
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors file watching change handling to improve the architecture by introducing a new handle_watched_file_change method on the Tool trait. The refactoring allows tools (linter and formatter) to handle watched file changes directly and report back what needs to be updated.
Key Changes:
- Added
handle_watched_file_changemethod to theTooltrait, allowing tools to handle file change events and return necessary updates - Removed three helper methods from
WorkspaceWorker(refresh_server_linter,refresh_server_formatter, andrevalidate_diagnostics) by delegating this logic to the tools themselves - Updated
did_change_watched_filesto return registration/unregistration information alongside diagnostics, matching the pattern used indid_change_configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_language_server/src/worker.rs | Removed helper methods and refactored did_change_watched_files to delegate to tools and handle dynamic watcher registration/unregistration |
| crates/oxc_language_server/src/tool.rs | Added handle_watched_file_change trait method for tools to process file change events |
| crates/oxc_language_server/src/linter/server_linter.rs | Implemented handle_watched_file_change for ServerLinter and changed revalidate_diagnostics visibility to private |
| crates/oxc_language_server/src/formatter/server_formatter.rs | Implemented handle_watched_file_change for ServerFormatter and moved early return check before options parsing |
| crates/oxc_language_server/src/backend.rs | Updated to handle registration/unregistration responses from did_change_watched_files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
11-08-feat_language_server_handle_new_watch_patterns_when_watched_file_is_changed
branch
from
cc637a8 to
b39159b
Compare
This was referenced Nov 8, 2025
camc314
approved these changes
Nov 9, 2025
Contributor
Merge activity
|
…_change` trait method (#15491) Returning `ToolRestartChanges` like `handle_configuration_change` does. The logic in `WorkspaceWorker/Backend` can be shared later for simplified usage.
graphite-app
bot
force-pushed
the
11-08-feat_language_server_handle_new_watch_patterns_when_watched_file_is_changed
branch
from
b39159b to
a2f2805
Compare
graphite-app
bot
deleted the
11-08-feat_language_server_handle_new_watch_patterns_when_watched_file_is_changed
branch
Copilot AI
pushed a commit
that referenced
this pull request
Nov 9, 2025
…_change` trait method (#15491) Returning `ToolRestartChanges` like `handle_configuration_change` does. The logic in `WorkspaceWorker/Backend` can be shared later for simplified usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning
ToolRestartChangeslikehandle_configuration_changedoes.The logic in
WorkspaceWorker/Backendcan be shared later for simplified usage.