refactor(language_server): implement Tool::shutdown trait method#15499
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 9, 2025
Merged
Conversation
Sysix
changed the title
Tool::shutdown trait methodTool::shutdown trait method
github-actions
bot
added
A-editor
This was referenced Nov 8, 2025
Merged
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
11-08-reactor_language_server_implement_tool_shutdown_trait_method
branch
2 times, most recently
from
3910ffd to
c38b086
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the diagnostics clearing mechanism during shutdown by introducing a new shutdown method to the Tool trait. The changes centralize shutdown logic at the tool level, making the cleanup process more consistent and maintainable.
Key changes:
- Added
shutdown()method to theTooltrait with a newToolShutdownChangesreturn type - Implemented
shutdown()inServerLinterto return URIs requiring diagnostic clearing - Replaced
get_clear_diagnostics()inWorkspaceWorkerwith a newshutdown()method that also handles file watcher unregistration - Updated
Backend::shutdown()andBackend::did_change_workspace_folders()to use the new shutdown mechanism
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/tool.rs | Adds shutdown() method to Tool trait and defines ToolShutdownChanges struct for returning shutdown-related changes |
| crates/oxc_language_server/src/linter/server_linter.rs | Implements shutdown() for ServerLinter and changes get_cached_files_of_diagnostics() visibility to private |
| crates/oxc_language_server/src/worker.rs | Replaces get_clear_diagnostics() with shutdown() method that returns both URIs and unregistrations |
| crates/oxc_language_server/src/backend.rs | Updates shutdown and workspace folder change handlers to use new shutdown mechanism and refactors clear_all_diagnostics() to clear_diagnostics() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
11-08-reactor_language_server_implement_tool_shutdown_trait_method
branch
2 times, most recently
from
2956e66 to
2e22526
Compare
camc314
approved these changes
Nov 9, 2025
Contributor
Merge activity
|
Sysix
force-pushed
the
11-08-refactor_language_server_move_llinter_formatter_methods_to_tool_trait
branch
from
51a4b40 to
3fc0c4c
Compare
Sysix
force-pushed
the
11-08-reactor_language_server_implement_tool_shutdown_trait_method
branch
from
2e22526 to
232076b
Compare
graphite-app
bot
force-pushed
the
11-08-refactor_language_server_move_llinter_formatter_methods_to_tool_trait
branch
from
3fc0c4c to
364ef4a
Compare
graphite-app
bot
force-pushed
the
11-08-reactor_language_server_implement_tool_shutdown_trait_method
branch
from
232076b to
77c5d30
Compare
Base automatically changed from
11-08-refactor_language_server_move_llinter_formatter_methods_to_tool_trait
to
main
November 9, 2025 00:46
graphite-app
bot
deleted the
11-08-reactor_language_server_implement_tool_shutdown_trait_method
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.