perf(napi/parser, linter/plugins): remove runtime `preserveParens` option from raw transfer deserializers by overlookmotel · Pull Request #14338 · oxc-project/oxc

overlookmotel · 2025-10-04T16:56:49Z

We had a runtime preserveParens option in deserializers to cater for linter, but it was not used in parser. Convert it to a compile-time option instead.

overlookmotel · 2025-10-04T16:57:03Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-04T17:02:36Z

CodSpeed Instrumentation Performance Report

Merging #14338 will not alter performance

_{Comparing 10-04-perf_napi_parser_linter_remove_runtime_preserveparens_option_from_raw_transfer_deserializers (e75d42d) with main (6374065)¹}

Summary

✅ 37 untouched

No successful run was found on main (e75d42d) during the generation of this report, so 6374065 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2025-10-04T17:03:00Z

Merge activity

Oct 4, 5:03 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Oct 4, 5:09 PM UTC: Merged by the Graphite merge queue.

…tion from raw transfer deserializers (#14338) We had a runtime `preserveParens` option in deserializers to cater for linter, but it was not used in parser. Convert it to a compile-time option instead.

## [1.20.0] - 2025-10-06 ### 🚀 Features - d16df93 linter: Support disable directives for type aware rules (#14052) (camc314) - f5c6acc linter: Add `vue/no-export-in-script-setup` rule (#14307) (Sysix) - 353b153 linter: Implement eslint/no-param-reassign rule (#14341) (Matthew Davis) - a2914fe linter/plugins: Add `loc` field getter to all AST nodes (#14355) (overlookmotel) - 07193c2 linter/plugins: Implement `SourceCode#getAncestors` (#14346) (overlookmotel) - c8de6fe linter/plugins: Add `parent` field to AST nodes (#14345) (overlookmotel) - 5505a86 linter/plugins: Include `range` field in AST (#14321) (overlookmotel) - 3656908 rust: Oxc-index-vec v4.0 (#14254) (Boshen) - 1347de4 linter/plugins: Accept diagnostics with `loc` (#14304) (overlookmotel) - aefc8b3 linter/plugins: Implement `SourceCode#getIndexFromLoc` and `getLocFromIndex` (#14303) (overlookmotel) - 93807db linter/plugins: Implement `SourceCode#lines` property (#14290) (overlookmotel) - 2f8c985 linter/plugins: Implement `SourceCode#visitorKeys` property (#14289) (overlookmotel) - b69028f linter/plugins: Implement `SourceCode#ast` property (#14287) (overlookmotel) - d8d3d18 linter: Add `vue/prefer-import-from-vue` rule (#14284) (Sysix) - f0e760b linter: Add `vue/define-props-destructuring` rule (#14272) (Sysix) - bdf9010 linter/plugins: Add `SourceCode` API (#14281) (overlookmotel) - 7f450fc linter/unicorn: Implement require-module-specifiers (#13089) (keita hino) - a1e7154 linter/unicorn: Implement prefer-classlist-toggle (#14262) (camc314) - 8217dce linter/unicorn: Implement no-unnecessary-array-splice-count (#14255) (camc314) - 3d5db4a linter/unicorn: Implement no-useless-error-capture-stack-trace (#14222) (camc314) - b3b482a linter/unicorn: Implement prefer-top-level-await (#14247) (camc314) - 7931be8 linter/unicorn: Implement prefer-class-fields (#14245) (camc314) - a39434a linter/unicorn: Implement prefer-at (#14232) (camc314) ### 🐛 Bug Fixes - e605222 linter/no-useless-undefined: Correctly respect `checkArguments` option (#14369) (camc314) - f1bc608 linter: Fix flaky import/no_cycle test (#14328) (Boshen) - 9a902c0 linter/plugins: Make `range` field non-optional on AST types (#14354) (overlookmotel) - 0a42d7f tsgolint: Report errors if we fail to parse tsgolint diagnostic messages (#14301) (camc314) - 42f8d7e linter/react-hooks: Fix diagnostic message for literal in dependency array (#14266) (camc314) - ece91c5 linter/react-hooks: Fix diagnostic message for duplicate dependency in array (#14265) (camc314) - 864fa0e linter/no-unused-expression: False positive with satisfies expressions (#14259) (camc314) - adff069 language_server: Don't apply "ignore this rule" fixes for fixAll code action + command (#14243) (Sysix) - 46cceb8 linter/rules-of-hooks: Correctly place primary span to fix disable directive (#14237) (camc314) ### 🚜 Refactor - 1489376 napi/parser, linter/plugins: Minify walker code (#14376) (overlookmotel) - c8eeeb5 linter/plugins: Remove build-time dependency on `napi/parser` (#14374) (overlookmotel) - fb1a067 linter/plugins: Bundle walker and AST types map (#14373) (overlookmotel) - 93d8164 linter/plugins: Export AST types direct from `oxlint` package (#14353) (overlookmotel) - 230d996 linter/plugins: `SourceCode#getText` use `range` (#14352) (overlookmotel) - 6e52bbd linter/plugins: Move location-related code into separate file (#14350) (overlookmotel) - 13f1003 linter/plugins: Share `ast` between files (#14349) (overlookmotel) - 00dde41 tsgolint: Make parsing `TsGoLintMessage` parsing errors an enum (#14300) (camc314) - fc314f5 tsgolint: Make `MessageType` parsing more idomatic (#14299) (camc314) - a24c36e language-server/tsgolint: Use an iterator for tsgolint message parsing (#14298) (camc314) - 8be432a tsgolint: Use an iterator for tsgolint message parsing (#14297) (camc314) - 57daa54 tsgolint: Remove always `Some` option wrapper (#14296) (camc314) - 79eadf8 linter: Introduce `LintRunner` (#14051) (camc314) - 65873ba linter/plugins: Add stubs for all `SourceCode` methods (#14285) (overlookmotel) - 989ce2f linter/plugins: Convert `Node` type to interface (#14280) (overlookmotel) - 891fc47 language_server: Share code for command `oxc.fixAll` and code action `source.fixAll.oxc` (#14244) (Sysix) - 7fe930c language_server: Remove unused fixture files (#14246) (Sysix) - 2b2c345 language-server: Move `generate_inverted_diagnostics` to `error_with_position` (#14118) (camc314) ### ⚡ Performance - fa3712d language_server: Create less `ExternalPluginStore`s (#14378) (overlookmotel) - e75d42d napi/parser, linter/plugins: Remove runtime `preserveParens` option from raw transfer deserializers (#14338) (overlookmotel) - 2e57351 linter/plugins: Initialize `lineStartOffsets` as `[0]` (#14302) (overlookmotel) - c27a393 linter/plugins: Deserialize AST on demand (#14288) (overlookmotel) - 95a8cc4 linter/plugins: Use singleton for `SourceCode` (#14286) (overlookmotel) ### 🧪 Testing - 0061ce7 linter: Add more tests for disable directives in partial loadable files (#14371) (camc314) - 1387aaa linter/plugins: Test `createOnce` returning no visitor functions (#14279) (overlookmotel) - 55ebb8b linter: Add test for `disable_for_this_section` fix (#14240) (Sysix) - a7e8662 linter: Port unicorn test cases to no-named-default (#14239) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

overlookmotel mentioned this pull request Oct 4, 2025

refactor(ast_tools/raw_transfer): remove support for flattening enums #14336

Merged

github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI A-ast Area - AST A-ast-tools Area - AST tools labels Oct 4, 2025

overlookmotel mentioned this pull request Oct 4, 2025

refactor(ast_tools/raw_transfer): simplify generating struct deserializer preamble #14337

Merged

github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Oct 4, 2025

overlookmotel mentioned this pull request Oct 4, 2025

fix(napi/parser, linter/plugins): add range field to TemplateElement #14339

Merged

overlookmotel marked this pull request as ready for review October 4, 2025 17:00

overlookmotel requested a review from camc314 as a code owner October 4, 2025 17:00

overlookmotel changed the title ~~perf(napi/parser, linter): remove runtime preserveParens option from raw transfer deserializers~~ perf(napi/parser, linter/plugins): remove runtime preserveParens option from raw transfer deserializers Oct 4, 2025

overlookmotel self-assigned this Oct 4, 2025

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025

perf(napi/parser, linter/plugins): remove runtime preserveParens op…

e75d42d

…tion from raw transfer deserializers (#14338) We had a runtime `preserveParens` option in deserializers to cater for linter, but it was not used in parser. Convert it to a compile-time option instead.

graphite-app bot force-pushed the 10-04-refactor_ast_tools_raw_transfer_simplify_generating_struct_deserializer_preamble branch from 17c1560 to c0562eb Compare October 4, 2025 17:04

graphite-app bot force-pushed the 10-04-perf_napi_parser_linter_remove_runtime_preserveparens_option_from_raw_transfer_deserializers branch from 21ae29d to e75d42d Compare October 4, 2025 17:04

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025

Base automatically changed from 10-04-refactor_ast_tools_raw_transfer_simplify_generating_struct_deserializer_preamble to main October 4, 2025 17:09

graphite-app bot merged commit e75d42d into main Oct 4, 2025
27 checks passed

graphite-app bot deleted the 10-04-perf_napi_parser_linter_remove_runtime_preserveparens_option_from_raw_transfer_deserializers branch October 4, 2025 17:09

This was referenced Oct 6, 2025

release(crates): v0.94.0 #14377

Merged

release(oxlint): v1.20.0 #14381

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

perf(napi/parser, linter/plugins): remove runtime `preserveParens` option from raw transfer deserializers#14338

perf(napi/parser, linter/plugins): remove runtime `preserveParens` option from raw transfer deserializers#14338
graphite-app[bot] merged 1 commit intomainfrom
10-04-perf_napi_parser_linter_remove_runtime_preserveparens_option_from_raw_transfer_deserializers

overlookmotel commented Oct 4, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Oct 4, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 4, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

overlookmotel commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #14338 will not alter performance

Summary

Footnotes

Uh oh!

graphite-app bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

overlookmotel commented Oct 4, 2025 •

edited

Loading

overlookmotel commented Oct 4, 2025 •

edited

Loading

codspeed-hq bot commented Oct 4, 2025 •

edited

Loading

graphite-app bot commented Oct 4, 2025 •

edited

Loading