Skip to content

refactor(ast_tools/raw_transfer): simplify generating struct deserializer preamble#14337

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-04-refactor_ast_tools_raw_transfer_simplify_generating_struct_deserializer_preamble
Oct 4, 2025
Merged

refactor(ast_tools/raw_transfer): simplify generating struct deserializer preamble#14337
graphite-app[bot] merged 1 commit intomainfrom
10-04-refactor_ast_tools_raw_transfer_simplify_generating_struct_deserializer_preamble

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 4, 2025

Pure refactor. Now that output is going through minifier, we can rely on it to conflate a series of variable declarations. No need to build a single variable declaration with multiple declarators any more.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 4, 2025
Copy link
Member Author

overlookmotel commented Oct 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 4, 2025

Merge activity

…izer preamble (#14337)

Pure refactor. Now that output is going through minifier, we can rely on it to conflate a series of variable declarations. No need to build a single variable declaration with multiple declarators any more.
@graphite-app graphite-app bot force-pushed the 10-04-refactor_ast_tools_raw_transfer_remove_support_for_flattening_enums branch from 5e2f923 to 5f328fe Compare October 4, 2025 17:03
@graphite-app graphite-app bot force-pushed the 10-04-refactor_ast_tools_raw_transfer_simplify_generating_struct_deserializer_preamble branch from 17c1560 to c0562eb Compare October 4, 2025 17:04
Base automatically changed from 10-04-refactor_ast_tools_raw_transfer_remove_support_for_flattening_enums to main October 4, 2025 17:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 4, 2025
@graphite-app graphite-app bot merged commit c0562eb into main Oct 4, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 10-04-refactor_ast_tools_raw_transfer_simplify_generating_struct_deserializer_preamble branch October 4, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant