feat(linter): support disable directives for type aware rules by camc314 · Pull Request #14052 · oxc-project/oxc

camc314 · 2025-09-23T15:08:37Z

camc314 · 2025-09-23T15:08:52Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-23T15:17:47Z

CodSpeed Performance Report

Merging #14052 will not alter performance

_{Comparing c/09-23-feat_linter_support_disable_directives_for_type_aware_rules (d16df93) with main (f88f5f4)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (fa3712d) during the generation of this report, so f88f5f4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2025-10-06T14:59:34Z

Merge activity

Oct 6, 2:59 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 6, 5:01 PM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 6, 5:07 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull Request Overview

This PR implements support for disable directives (like eslint-disable and oxlint-disable) for type-aware rules, addressing issue #13941. The implementation adds centralized disable directives handling that works across both regular oxc linting and type-aware tsgolint linting.

Key changes:

Centralized disable directives coordination through a new DirectivesStore that manages shared state between linting engines
Enhanced LintRunner to collect disable directives during regular linting and apply them to type-aware linting
Integration of disable directive checking in TsGoLintState to filter out suppressed diagnostics

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`editors/vscode/tests/code_actions.spec.ts`	Temporarily disabled test related to unused disable directives configuration
`crates/oxc_linter/src/tsgolint.rs`	Added disable directives filtering for type-aware linting diagnostics
`crates/oxc_linter/src/service/runtime.rs`	Modified to collect and store disable directives during linting
`crates/oxc_linter/src/service/mod.rs`	Added method to set disable directives map on lint service
`crates/oxc_linter/src/lint_runner.rs`	Added new `DirectivesStore` for centralized disable directives management
`crates/oxc_linter/src/lib.rs`	Exposed disable directives utilities and modified linter to return directives
`crates/oxc_linter/src/disable_directives.rs`	Added utility function to create unused directives diagnostics
`crates/oxc_linter/src/context/host.rs`	Added method to extract disable directives from context host
`crates/oxc_language_server/src/snapshots/*`	Updated test snapshots to reflect removal of fix suggestions for unused directives
`crates/oxc_language_server/src/linter/*`	Updated language server linting to handle disable directives
`apps/oxlint/src/snapshots/*`	Added test snapshots for disable directives with type-aware rules
`apps/oxlint/src/lint.rs`	Modified to use new lint runner API and report unused directives
`apps/oxlint/fixtures/tsgolint_disable_directives/*`	Added test fixtures for disable directives functionality

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/tsgolint.rs

crates/oxc_linter/src/service/runtime.rs

crates/oxc_linter/src/lint_runner.rs

apps/oxlint/src/lint.rs

fixes #13941

## [1.20.0] - 2025-10-06 ### 🚀 Features - d16df93 linter: Support disable directives for type aware rules (#14052) (camc314) - f5c6acc linter: Add `vue/no-export-in-script-setup` rule (#14307) (Sysix) - 353b153 linter: Implement eslint/no-param-reassign rule (#14341) (Matthew Davis) - a2914fe linter/plugins: Add `loc` field getter to all AST nodes (#14355) (overlookmotel) - 07193c2 linter/plugins: Implement `SourceCode#getAncestors` (#14346) (overlookmotel) - c8de6fe linter/plugins: Add `parent` field to AST nodes (#14345) (overlookmotel) - 5505a86 linter/plugins: Include `range` field in AST (#14321) (overlookmotel) - 3656908 rust: Oxc-index-vec v4.0 (#14254) (Boshen) - 1347de4 linter/plugins: Accept diagnostics with `loc` (#14304) (overlookmotel) - aefc8b3 linter/plugins: Implement `SourceCode#getIndexFromLoc` and `getLocFromIndex` (#14303) (overlookmotel) - 93807db linter/plugins: Implement `SourceCode#lines` property (#14290) (overlookmotel) - 2f8c985 linter/plugins: Implement `SourceCode#visitorKeys` property (#14289) (overlookmotel) - b69028f linter/plugins: Implement `SourceCode#ast` property (#14287) (overlookmotel) - d8d3d18 linter: Add `vue/prefer-import-from-vue` rule (#14284) (Sysix) - f0e760b linter: Add `vue/define-props-destructuring` rule (#14272) (Sysix) - bdf9010 linter/plugins: Add `SourceCode` API (#14281) (overlookmotel) - 7f450fc linter/unicorn: Implement require-module-specifiers (#13089) (keita hino) - a1e7154 linter/unicorn: Implement prefer-classlist-toggle (#14262) (camc314) - 8217dce linter/unicorn: Implement no-unnecessary-array-splice-count (#14255) (camc314) - 3d5db4a linter/unicorn: Implement no-useless-error-capture-stack-trace (#14222) (camc314) - b3b482a linter/unicorn: Implement prefer-top-level-await (#14247) (camc314) - 7931be8 linter/unicorn: Implement prefer-class-fields (#14245) (camc314) - a39434a linter/unicorn: Implement prefer-at (#14232) (camc314) ### 🐛 Bug Fixes - e605222 linter/no-useless-undefined: Correctly respect `checkArguments` option (#14369) (camc314) - f1bc608 linter: Fix flaky import/no_cycle test (#14328) (Boshen) - 9a902c0 linter/plugins: Make `range` field non-optional on AST types (#14354) (overlookmotel) - 0a42d7f tsgolint: Report errors if we fail to parse tsgolint diagnostic messages (#14301) (camc314) - 42f8d7e linter/react-hooks: Fix diagnostic message for literal in dependency array (#14266) (camc314) - ece91c5 linter/react-hooks: Fix diagnostic message for duplicate dependency in array (#14265) (camc314) - 864fa0e linter/no-unused-expression: False positive with satisfies expressions (#14259) (camc314) - adff069 language_server: Don't apply "ignore this rule" fixes for fixAll code action + command (#14243) (Sysix) - 46cceb8 linter/rules-of-hooks: Correctly place primary span to fix disable directive (#14237) (camc314) ### 🚜 Refactor - 1489376 napi/parser, linter/plugins: Minify walker code (#14376) (overlookmotel) - c8eeeb5 linter/plugins: Remove build-time dependency on `napi/parser` (#14374) (overlookmotel) - fb1a067 linter/plugins: Bundle walker and AST types map (#14373) (overlookmotel) - 93d8164 linter/plugins: Export AST types direct from `oxlint` package (#14353) (overlookmotel) - 230d996 linter/plugins: `SourceCode#getText` use `range` (#14352) (overlookmotel) - 6e52bbd linter/plugins: Move location-related code into separate file (#14350) (overlookmotel) - 13f1003 linter/plugins: Share `ast` between files (#14349) (overlookmotel) - 00dde41 tsgolint: Make parsing `TsGoLintMessage` parsing errors an enum (#14300) (camc314) - fc314f5 tsgolint: Make `MessageType` parsing more idomatic (#14299) (camc314) - a24c36e language-server/tsgolint: Use an iterator for tsgolint message parsing (#14298) (camc314) - 8be432a tsgolint: Use an iterator for tsgolint message parsing (#14297) (camc314) - 57daa54 tsgolint: Remove always `Some` option wrapper (#14296) (camc314) - 79eadf8 linter: Introduce `LintRunner` (#14051) (camc314) - 65873ba linter/plugins: Add stubs for all `SourceCode` methods (#14285) (overlookmotel) - 989ce2f linter/plugins: Convert `Node` type to interface (#14280) (overlookmotel) - 891fc47 language_server: Share code for command `oxc.fixAll` and code action `source.fixAll.oxc` (#14244) (Sysix) - 7fe930c language_server: Remove unused fixture files (#14246) (Sysix) - 2b2c345 language-server: Move `generate_inverted_diagnostics` to `error_with_position` (#14118) (camc314) ### ⚡ Performance - fa3712d language_server: Create less `ExternalPluginStore`s (#14378) (overlookmotel) - e75d42d napi/parser, linter/plugins: Remove runtime `preserveParens` option from raw transfer deserializers (#14338) (overlookmotel) - 2e57351 linter/plugins: Initialize `lineStartOffsets` as `[0]` (#14302) (overlookmotel) - c27a393 linter/plugins: Deserialize AST on demand (#14288) (overlookmotel) - 95a8cc4 linter/plugins: Use singleton for `SourceCode` (#14286) (overlookmotel) ### 🧪 Testing - 0061ce7 linter: Add more tests for disable directives in partial loadable files (#14371) (camc314) - 1387aaa linter/plugins: Test `createOnce` returning no visitor functions (#14279) (overlookmotel) - 55ebb8b linter: Add test for `disable_for_this_section` fix (#14240) (Sysix) - a7e8662 linter: Port unicorn test cases to no-named-default (#14239) (camc314) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

overlookmotel · 2025-10-06T17:45:54Z

Bravo!

#14052 created diagnostics without a fix. Fixed it for the language server, maybe the CLI should support this too with `--fix --report-unused-disable-directives`. It was at least possible before the PR.

oxc-project/oxc#14052 created diagnostics without a fix. Fixed it for the language server, maybe the CLI should support this too with `--fix --report-unused-disable-directives`. It was at least possible before the PR.

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server labels Sep 23, 2025

github-actions bot added the C-enhancement Category - New feature or request label Sep 23, 2025

This was referenced Sep 23, 2025

refactor(linter): rename LintRunner to CliRunner #14050

Merged

refactor(linter): introduce LintRunner #14051

Merged

camc314 self-assigned this Sep 23, 2025

camc314 force-pushed the c/09-23-refactor_linter_introduce_lintrunner_ branch from f67a39e to b093549 Compare September 23, 2025 15:12

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from 41ea359 to d63f550 Compare September 23, 2025 15:12

graphite-app bot force-pushed the c/09-23-refactor_linter_introduce_lintrunner_ branch 2 times, most recently from 42e96b5 to f9fbad1 Compare September 24, 2025 12:06

camc314 force-pushed the c/09-23-refactor_linter_introduce_lintrunner_ branch from f9fbad1 to 6602e89 Compare September 25, 2025 12:40

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from d63f550 to 9222f33 Compare September 25, 2025 12:40

camc314 mentioned this pull request Sep 25, 2025

refactor(language-server): move generate_inverted_diagnostics to error_with_position #14118

Merged

camc314 force-pushed the c/09-23-refactor_linter_introduce_lintrunner_ branch from 6602e89 to 0a2a774 Compare September 25, 2025 13:43

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from 9222f33 to f009d6f Compare September 25, 2025 13:43

camc314 force-pushed the c/09-23-refactor_linter_introduce_lintrunner_ branch 3 times, most recently from 4196bea to 78b185a Compare October 2, 2025 09:08

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from f009d6f to ba4fd63 Compare October 2, 2025 09:09

graphite-app bot changed the base branch from c/09-23-refactor_linter_introduce_lintrunner_ to graphite-base/14052 October 2, 2025 09:14

graphite-app bot force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from ba4fd63 to 0dc71c1 Compare October 2, 2025 09:20

graphite-app bot force-pushed the graphite-base/14052 branch from 78b185a to 79eadf8 Compare October 2, 2025 09:20

graphite-app bot changed the base branch from graphite-base/14052 to main October 2, 2025 09:21

graphite-app bot force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from 0dc71c1 to 8bf5013 Compare October 2, 2025 09:21

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch 2 times, most recently from f4a928e to d492f10 Compare October 2, 2025 09:57

camc314 changed the base branch from main to graphite-base/14052 October 2, 2025 13:01

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch 9 times, most recently from c052b04 to b842366 Compare October 6, 2025 14:57

camc314 marked this pull request as ready for review October 6, 2025 14:59

camc314 requested a review from Sysix as a code owner October 6, 2025 14:59

camc314 requested review from Copilot and removed request for Sysix October 6, 2025 14:59

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025

Copilot AI reviewed Oct 6, 2025

View reviewed changes

camc314 force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch 2 times, most recently from b4142df to d2992b7 Compare October 6, 2025 16:56

feat(linter): support disable directives for type aware rules (#14052)

d16df93

fixes #13941

graphite-app bot force-pushed the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch from d2992b7 to d16df93 Compare October 6, 2025 17:02

graphite-app bot merged commit d16df93 into main Oct 6, 2025
21 checks passed

graphite-app bot deleted the c/09-23-feat_linter_support_disable_directives_for_type_aware_rules branch October 6, 2025 17:07

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 6, 2025

Boshen mentioned this pull request Oct 6, 2025

release(oxlint): v1.20.0 #14381

Merged

overlookmotel mentioned this pull request Oct 6, 2025

linter: disable comments are not respected by type aware rules #13491

Closed

Sysix mentioned this pull request Oct 21, 2025

fix(language_server): make unused directives fixable again #14872

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(linter): support disable directives for type aware rules#14052

feat(linter): support disable directives for type aware rules#14052
graphite-app[bot] merged 1 commit intomainfrom
c/09-23-feat_linter_support_disable_directives_for_type_aware_rules

camc314 commented Sep 23, 2025 •

edited by overlookmotel

Loading

Uh oh!

camc314 commented Sep 23, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

camc314 commented Oct 6, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

camc314 commented Sep 23, 2025 • edited by overlookmotel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14052 will not alter performance

Summary

Footnotes

Uh oh!

camc314 commented Oct 6, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

overlookmotel commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Sep 23, 2025 •

edited by overlookmotel

Loading

camc314 commented Sep 23, 2025 •

edited

Loading

codspeed-hq bot commented Sep 23, 2025 •

edited

Loading

camc314 commented Oct 6, 2025 •

edited by graphite-app bot

Loading