docs(napi/oxlint): add comments#13712
Merged
graphite-app[bot] merged 1 commit intomainfrom Sep 12, 2025
Merged
Conversation
github-actions
bot
added
the
C-docs
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
09-12-docs_napi_oxlint_add_comments
branch
from
cf1d3b8 to
cb922fe
Compare
graphite-app
bot
force-pushed
the
09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32
branch
2 times, most recently
from
09e3ad1 to
3aff5a3
Compare
graphite-app
bot
force-pushed
the
09-12-docs_napi_oxlint_add_comments
branch
from
cb922fe to
3f5db19
Compare
overlookmotel
force-pushed
the
09-12-docs_napi_oxlint_add_comments
branch
from
3f5db19 to
7798c53
Compare
overlookmotel
force-pushed
the
09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32
branch
from
3aff5a3 to
09e3ad1
Compare
camc314
approved these changes
Sep 12, 2025
graphite-app
bot
changed the base branch from
09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32
to
graphite-base/13712
Contributor
Merge activity
|
camc314
force-pushed
the
09-12-docs_napi_oxlint_add_comments
branch
from
7798c53 to
69f7baf
Compare
camc314
force-pushed
the
graphite-base/13712
branch
from
09e3ad1 to
7d462fa
Compare
Docs/comments only. Document all functions in `napi/oxlint` crate + update safety comment in `wrap_lint_file`.
graphite-app
bot
force-pushed
the
09-12-docs_napi_oxlint_add_comments
branch
from
69f7baf to
5f56b09
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
Convert `oxlint` to a NAPI package. This PR: 1. Moves files from `napi/oxlint` into `apps/oxlint`. 2. Converts `oxlint` into a NAPI package. 3. Alters the [release workflow](https://github.com/oxc-project/oxc/pull/13723/files#diff-80cb497c859bbaf7756da6ced2bca3d31933affc96102983eee1ad7d4bcc60fd) and [script](https://github.com/oxc-project/oxc/pull/13723/files#diff-4c4b7045c68805aeeae7c0af94cf7cf7487cb0403496da974a6a23accdc457d0) for building `oxlint` packages. Most of necessary code modifications and refactoring was done in previous PRs (#13701, #13712, #13722, #13745), so this PR only includes changes necessary for packaging as NAPI. I've done my best to update release workflow, but am mostly "flying blind" without ability to test it, so very likely there are mistakes. A few notes and oddities: * I've kept the `oxlint` NPM package as CommonJS. We could probably switch to ESM, but I thought it better to minimize the changes in this PR. * NAPI-RS creates `.node` files named with a `-msvc` postfix for Windows. The scripts here remove that postfix so that filename of `.node` files and NPM package names match for all platforms, for simplicity. * `tasks/website` has a dependency on `oxlint` as a normal library. This resulted in linker errors, so have had to put all the NAPI stuff behind `napi` cargo feature. Tests for `tasks/website` are run separately in CI, to avoid feature unification turning on the `napi` feature for `website`. I've made a few comments below for the parts which aren't fairly self-explanatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs/comments only. Document all functions in
napi/oxlintcrate + update safety comment inwrap_lint_file.