Skip to content

Comments

refactor(napi/oxlint): move external linter construction into own module#13710

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-12-refactor_napi_oxlint_move_external_linter_construction_into_own_module
Sep 12, 2025
Merged

refactor(napi/oxlint): move external linter construction into own module#13710
graphite-app[bot] merged 1 commit intomainfrom
09-12-refactor_napi_oxlint_move_external_linter_construction_into_own_module

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 12, 2025

Pure refactor. Move wrap_* functions into separate external_linter.rs module, and add a create_external_linter function which wraps both JS callbacks.

This is necessary so we can feature gate loading the module (next PR #13711).

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 12, 2025
Copy link
Member Author

overlookmotel commented Sep 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 12, 2025 04:57
Copilot AI review requested due to automatic review settings September 12, 2025 04:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the external linter construction code by moving the wrap_* functions from lib.rs into a separate external_linter.rs module. The refactor creates a single create_external_linter function that encapsulates both JS callback wrapping operations.

  • Moved external linter wrapper functions to a dedicated module
  • Added a convenience function to create external linter instances
  • Simplified the main lint function by delegating construction logic

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
napi/oxlint/src/lib.rs Removed external linter construction code and simplified imports, added module declaration and delegation to new module
napi/oxlint/src/external_linter.rs New module containing all external linter construction logic moved from lib.rs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel self-assigned this Sep 12, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
Copy link
Member Author

overlookmotel commented Sep 12, 2025

Merge activity

…ule (#13710)

Pure refactor. Move `wrap_*` functions into separate `external_linter.rs` module, and add a `create_external_linter` function which wraps both JS callbacks.

This is necessary so we can feature gate loading the module (next PR #13711).
@graphite-app graphite-app bot force-pushed the 09-12-refactor_napi_oxlint_move_external_linter_construction_into_own_module branch from 94673db to 079c2f2 Compare September 12, 2025 05:16
@graphite-app graphite-app bot merged commit 079c2f2 into main Sep 12, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-12-refactor_napi_oxlint_move_external_linter_construction_into_own_module branch September 12, 2025 05:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants