Skip to content

Comments

fix(napi/oxlint): prevent compilation failure on WASM32#13711

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32
Sep 12, 2025
Merged

fix(napi/oxlint): prevent compilation failure on WASM32#13711
graphite-app[bot] merged 1 commit intomainfrom
09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 12, 2025 •
edited
Loading

It is a compilation error to load generated::raw_transfer_constants on 32-bit platforms, and JS plugins are only supported on little-endian 64-bit platforms.

Feature gate all JS plugin-related code so it does not get loaded on unsupported platforms. This should allow napi/oxlint to be built as WASM32.

@github-actions github-actions bot added the C-bug Category - Bug label Sep 12, 2025
@overlookmotel overlookmotel mentioned this pull request Sep 12, 2025
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Sep 12, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Sep 12, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review September 12, 2025 04:59
@graphite-app graphite-app bot changed the base branch from 09-12-refactor_napi_oxlint_move_external_linter_construction_into_own_module to graphite-base/13711 September 12, 2025 05:16
graphite-app bot pushed a commit that referenced this pull request Sep 12, 2025
@overlookmotel
refactor(napi/oxlint): move external linter construction into own mod…
079c2f2 
…ule (#13710)

Pure refactor. Move `wrap_*` functions into separate `external_linter.rs` module, and add a `create_external_linter` function which wraps both JS callbacks.

This is necessary so we can feature gate loading the module (next PR #13711).
@graphite-app graphite-app bot force-pushed the 09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32 branch from 8955470 to 09e3ad1 Compare September 12, 2025 05:22
@graphite-app graphite-app bot force-pushed the graphite-base/13711 branch from 94673db to 079c2f2 Compare September 12, 2025 05:22
@graphite-app graphite-app bot changed the base branch from graphite-base/13711 to main September 12, 2025 05:23
@graphite-app graphite-app bot force-pushed the 09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32 branch from 09e3ad1 to 3aff5a3 Compare September 12, 2025 05:23
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Sep 12, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel overlookmotel force-pushed the 09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32 branch from 3aff5a3 to 09e3ad1 Compare September 12, 2025 05:27
@overlookmotel
fix(napi/oxlint): prevent compilation failure on WASM32 (#13711)
7d462fa 
It is a compilation error to load `generated::raw_transfer_constants` on 32-bit platforms, and JS plugins are only supported on little-endian 64-bit platforms.

Feature gate all JS plugin-related code so it does not get loaded on unsupported platforms. This should allow `napi/oxlint` to be built as WASM32.
@graphite-app graphite-app bot force-pushed the 09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32 branch from 09e3ad1 to 7d462fa Compare September 12, 2025 05:28
@graphite-app graphite-app bot merged commit 7d462fa into main Sep 12, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 09-12-fix_napi_oxlint_prevent_compilation_failure_on_wasm32 branch September 12, 2025 05:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 12, 2025
@robertkirkman robertkirkman mentioned this pull request Sep 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314