refactor(linter/plugins): remove oxlint2 Cargo feature

[overlookmotel]

Remove oxlint2 Cargo feature from oxlint and oxc_linter crates.

Now that enabling fixed_size Cargo feature of oxc_allocator doesn't change behavior, we don't need the feature gate. The incompatibility of tokio with WASM has been resolved by #13647.

[overlookmotel]

• refactor(linter/plugins): remove oxlint2 Cargo feature #13648 👈 (View in Graphite)
• refactor(linter/plugins): move tokio usage from oxc_linter to napi/oxlint2 #13647
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13648 will not alter performance

_{Comparing 09-10-refactor_linter_plugins_remove_oxlint2_cargo_feature (7775c21) with main (08cbd39)¹}

Summary

✅ 37 untouched benchmarks

Footnotes

1. No successful run was found on main (7775c21) during the generation of this report, so 08cbd39 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[overlookmotel]

@camc314 Is this a good idea?

Language server: At present, removing the oxlint2 feature causes some code which never runs to get compiled in language server. But presumably pretty soon we'll want to add JS plugin support to language server too, at which point it won't be dead code any more.

Playground: The playground probably isn't going to support linter JS plugins any time soon (how would you provide the plugin?), so removing the feature will cause some wasted bytes in the playground's WASM file.

On the positive side, this does remove quite a bit of mess and complexity.

[camc314]

Yes, i think this is a good idea. It simplifies the code which is good. I don't think the playground will ever (i guess technically we could but probably more effort than it's worth) support custom JS plugins. Language server will definitely support this (at some point)

[overlookmotel]

Merge activity

• Sep 11, 6:17 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 11, 6:17 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Sep 11, 6:23 AM UTC: Merged by the Graphite merge queue.

[Copilot]

Pull Request Overview

This PR removes the oxlint2 Cargo feature from the oxlint and oxc_linter crates. The feature gate is no longer necessary since enabling the fixed_size Cargo feature of oxc_allocator doesn't change behavior, and WASM compatibility issues with tokio have been resolved.

Key changes:

• Remove conditional compilation blocks gated by oxlint2 feature
• Enable fixed_size allocator features unconditionally
• Clean up unused feature dependencies and configurations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
napi/oxlint2/Cargo.toml	Remove oxlint2 feature from oxlint dependency
crates/oxc_linter/src/service/runtime.rs	Remove feature-gated allocator selection logic
crates/oxc_linter/src/lib.rs	Remove conditional compilation for external rule functionality
crates/oxc_linter/src/external_linter.rs	Remove dead code attribute
crates/oxc_linter/src/config/config_store.rs	Remove dead code attribute
crates/oxc_linter/src/config/config_builder.rs	Remove unused feature-gated function variant
crates/oxc_linter/Cargo.toml	Update feature configuration and dependencies
apps/oxlint/src/lint.rs	Remove conditional compilation for external linter
apps/oxlint/src/lib.rs	Remove conditional module inclusion
apps/oxlint/Cargo.toml	Update dependencies and remove feature

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}