refactor(linter/plugins): use fixed-size allocators when ExternalLinter exists

[overlookmotel]

We're trying to move the linter away from relying on Cargo features to enable/disable support for JS plugins, and over to runtime options.

The signal that JS plugins are in use is the existence of an ExternalLinter.

Select what kind of AllocatorPool to use based on this criteria - fixed-size allocators if JS plugins are in use, or standard allocators otherwise. Utilize the AllocatorPool::new_fixed_size method added in #13622 to do this.

[overlookmotel]

• refactor(linter/plugins): remove disable_oxlint2 Cargo feature #13626
• refactor(allocator/pool)!: remove disable_fixed_size Cargo feature #13625
• refactor(allocator/pool): AllocatorPool::new always create standard pool #13624
• refactor(linter/plugins): use fixed-size allocators when ExternalLinter exists #13623 👈 (View in Graphite)
• refactor(allocator/pool): single AllocatorPool implementation #13622
• refactor(allocator/pool): share AllocatorGuard between pool impls #13621
• refactor(allocator/pool): move resetting into AllocatorPool::add #13620
• refactor(allocator/pool): move AllocatorPool into own directory #13619
• refactor(all): remove pub from modules with no exports #13618
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13623 will not alter performance

_{Comparing 09-09-refactor_linter_plugins_use_fixed-size_allocators_when_externallinter_exists (ff9e4fb) with main (3d27c5b)¹}

Summary

✅ 37 untouched benchmarks

Footnotes

1. No successful run was found on main (ff9e4fb) during the generation of this report, so 3d27c5b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[graphite-app]

Merge activity

• Sep 10, 4:00 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Sep 10, 4:22 AM UTC: Merged by the Graphite merge queue.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	right-pad@​1.1.1
	lodash.isarray@​4.0.0
	react@​16.14.0
	lodash.cond@​4.5.2
	find-up@​1.1.2
	left-pad@​1.3.0
	acorn@​1.2.2
	a@​4.0.0
	jquery@​3.7.1
	three@​0.180.0
	@​react-three/​fiber@​9.3.0
	eslint@​9.35.0 ⏵ 2.13.1	+1

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		es5-ext@0.10.64 is Protestware or potentially unwanted behavior. Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale From: ? → npm/eslint@2.13.1 → npm/es5-ext@0.10.64 ℹ Read more on: This package | This alert | What is protestware? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Consider that consuming this package may come along with functionality unrelated to its primary purpose. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/es5-ext@0.10.64. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		es5-ext@0.10.64 is Protestware or potentially unwanted behavior. Note: The script attempts to run a local post-install script, which could potentially contain malicious code. The error handling suggests that it is designed to fail silently, which is a common tactic in malicious scripts. From: ? → npm/eslint@2.13.1 → npm/es5-ext@0.10.64 ℹ Read more on: This package | This alert | What is protestware? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Consider that consuming this package may come along with functionality unrelated to its primary purpose. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/es5-ext@0.10.64. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.