fix(language_server): include the diagnostic of the other linter by Sysix · Pull Request #13490 · oxc-project/oxc

Sysix · 2025-08-31T18:05:58Z

Not the ServerLinter and WorkspaceWorker are holding the diagnostics of a file.
The next PR will refactor it, so WorkspaceWorker will no longer hold a copy of it.

Wanted to be ready for a possible patch release

closes #13480

Sysix · 2025-08-31T18:06:13Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-08-31T18:12:38Z

CodSpeed Instrumentation Performance Report

Merging #13490 will not alter performance

_{Comparing 08-31-fix_language_server_include_the_diagnostic_of_the_other_linter (b677376) with main (1b425d6)¹}

Summary

✅ 37 untouched benchmarks

No successful run was found on main (b677376) during the generation of this report, so 1b425d6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull Request Overview

This PR implements diagnostic aggregation from multiple linters (ServerLinter and WorkspaceWorker) in preparation for a refactoring that will centralize diagnostic storage. The change ensures both oxlint and tsgo linter diagnostics are properly combined and returned.

Refactored ServerLinter to store diagnostics from both isolated and tsgo linters separately
Added test infrastructure for writing to fixture files and getting diagnostics without closing editors
Created a new test case to verify diagnostics detection on file changes

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File	Description
`crates/oxc_language_server/src/linter/server_linter.rs`	Added diagnostic aggregation structure to combine diagnostics from multiple linters
`editors/vscode/tests/test-helpers.ts`	Added helper functions for writing to files and getting diagnostics without closing editors
`editors/vscode/tests/e2e_server.spec.ts`	Added test case for diagnostic detection on file changes
`editors/vscode/fixtures/lint_on_run/.oxlintrc.json`	Added configuration file for the new test fixture

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

editors/vscode/tests/test-helpers.ts

camc314 · 2025-09-02T03:03:23Z

Merge activity

Sep 2, 3:03 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 2, 3:03 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 2, 3:07 AM UTC: Merged by the Graphite merge queue.

) Not the `ServerLinter` and `WorkspaceWorker` are holding the diagnostics of a file. The next PR will refactor it, so `WorkspaceWorker` will no longer hold a copy of it. Wanted to be ready for a possible patch release closes #13480

## [1.15.0] - 2025-09-11 ### 💥 BREAKING CHANGES - edc70ea allocator/pool: [**BREAKING**] Remove `disable_fixed_size` Cargo feature (#13625) (overlookmotel) ### 🚀 Features - b20b56d linter: Add `vue/no-multiple-slot-args` rule (#13579) (Sysix) - aafe08c linter: Add `vue/define-emits-declaration` rule (#13567) (Sysix) - 2ed5059 linter: Add `vue/define-props-declaration` rule (#13566) (Sysix) - a718c23 linter: Add `vue/valid-define-props` rule (#13565) (Sysix) - 75a673e editor: Support relative path for `oxc.path.server` (#13542) (Sysix) - 4af886b linter: Add `unicorn/no-array-reverse` rule (#13530) (yefan) - 2db32eb data_structures: Add `boxed_slice!` and `boxed_array!` macros (#13596) (overlookmotel) ### 🐛 Bug Fixes - fb9d0f4 language_server: Don't resend diagnostic on save, when `typeAware` is disabled and run is onType (#13604) (YongSeok Jang (장용석)) - 2f36350 editor: Add notice for a possible restart when fixing `filename-case` (#13557) (Sysix) - e17fccc linter: Update `RuleRunner` impl after merge (#13642) (camc314) - 3d27c5b linter/no-unused-private-class-members: False positive with spread expr (#13634) (yefan) - 8314ed5 linter/tsgolint: Correct comment (#13589) (camc314) - 198243b semantic: Dont parse `@` as jsdoc tags inside quotes (#13571) (Gwenn Le Bihan) - 89084d7 linter/custom-plugins: Enforce exact matching for disable directives (#13538) (Copilot) - 277c5e1 linter: Output `eslint-plugin-vue` for vue diagnostics (#13564) (Sysix) - 34d3cde rust: Fix clippy issues (#13540) (Boshen) - 5fccafc linter: `unicorn/prefer-array-flat-map` ignore `React.Children` (#13534) (Sysix) - 7e78e39 linter: Don't panic when parsing regex with multiple parentheses (#13524) (Sysix) - 0d867b1 linter: Skip running tsgolint when no files need type aware linting (#13502) (Copilot) - b677376 language_server: Include the diagnostic of the other linter (#13490) (Sysix) - e87d7bd linter: Parse regex inside `new RegExp()` with parentheses (#13448) (Sysix) - 5990f17 linter: Change `typescript/no-confusing-void-expression` to pedantic (#13473) (Boshen) ### 🚜 Refactor - 7775c21 linter/plugins: Remove `oxlint2` Cargo feature (#13648) (overlookmotel) - 8f37e88 linter: Update tsgolint payload (#13547) (camchenry) - 2d53203 linter/plugins: Move `tokio` usage from `oxc_linter` to `napi/oxlint2` (#13647) (overlookmotel) - 6cd6be2 linter: Add `--experimental-js-plugins` CLI arg (#13658) (overlookmotel) - 476729b linter: Simplify `RuleRunner` trait definition (#13637) (camchenry) - 2f02ac6 linter/plugins: Remove `disable_oxlint2` Cargo feature (#13626) (overlookmotel) - ff9e4fb linter/plugins: Use fixed-size allocators when `ExternalLinter` exists (#13623) (overlookmotel) - f9bff64 linter_codegen: Improve code style for collecting nodes (#13636) (camchenry) - babbaca all: Remove `pub` from modules with no exports (#13618) (overlookmotel) - 91759c6 linter/plugins: Only use `RawTransferFileSystem` if JS plugins registered (#13599) (overlookmotel) - 118020c linter/plugins: Discard `ExternalLinter` if no JS plugins registered (#13598) (overlookmotel) - 8d30bce linter/tsgolint: Report an error if the tsgolint exe could not be found (#13590) (camc314) - bccc276 eslint/for-direction: Clean up implementation and improve documentation (#13532) (Antoine Zanardi) - 1425da2 eslint/default-case-last: Simplify default case last check in switch statement (#13529) (Antoine Zanardi) - d245376 oxlint: Remove unused `runner` module (#13561) (camc314) - 53f2fc1 eslint/default-case: Simplify implementation and enhance readability (#13430) (Antoine Zanardi) - 6f15060 eslint/block-scoped-var: Clean up implementation and improve documentation (#13417) (Antoine Zanardi) - 671e0fd language_server: Only store one instance of a diagnostic (#13514) (Sysix) - 1b425d6 eslint/default-case-last: Simplify implementation and enhance readability (#13515) (Antoine Zanardi) - e4bbbce eslint/default-param-last: Simplify implementation and enhance readability (#13516) (Antoine Zanardi) - e0396fd linter: Remove `static` lifetime from disable directives function argument (#13492) (camc314) ### 📚 Documentation - eb1f167 linter: Note which rules require type info to run on rule page (#13675) (camc314) - e66f93b linter: Fix backtick formatting in no-return-wrap (#13633) (camc314) ### ⚡ Performance - e6a25e7 linter: Remove unnecessary `should_run` check (#13639) (camchenry) - f6a9687 linter: Store rules by AST type in a boxed array (#13578) (overlookmotel) - b81f081 linter: Reduce indirection (#13574) (overlookmotel) - a744aff linter: Skip rules that do not have any relevant node types (#13138) (camchenry) ### 🎨 Styling - e110476 linter: Reformat code (#13573) (overlookmotel) ### 🧪 Testing - 58e6c94 oxlint: Add test for ignorePatterns whitelist (#13372) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Aug 31, 2025

Sysix mentioned this pull request Aug 31, 2025

linter: VSCode stops showing errors after saving until the file is changed again #13480

Closed

Sysix force-pushed the 08-31-fix_language_server_include_the_diagnostic_of_the_other_linter branch from a5a8c9e to 85c19b0 Compare September 1, 2025 16:21

Sysix marked this pull request as ready for review September 1, 2025 16:26

Copilot AI review requested due to automatic review settings September 1, 2025 16:26

Sysix requested a review from camc314 as a code owner September 1, 2025 16:26

Copilot AI reviewed Sep 1, 2025

View reviewed changes

editors/vscode/tests/test-helpers.ts Show resolved Hide resolved

Sysix force-pushed the 08-31-fix_language_server_include_the_diagnostic_of_the_other_linter branch from 85c19b0 to a6110a7 Compare September 1, 2025 17:24

Sysix mentioned this pull request Sep 1, 2025

refactor(language_server): only store one instance of a diagnostic #13514

Merged

camc314 approved these changes Sep 2, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 2, 2025

graphite-app bot force-pushed the 08-31-fix_language_server_include_the_diagnostic_of_the_other_linter branch from a6110a7 to b677376 Compare September 2, 2025 03:03

graphite-app bot merged commit b677376 into main Sep 2, 2025
25 checks passed

graphite-app bot deleted the 08-31-fix_language_server_include_the_diagnostic_of_the_other_linter branch September 2, 2025 03:07

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 2, 2025

Sysix mentioned this pull request Sep 9, 2025

fix(language_server): don't resend diagnostic on save, when typeAware is disabled and run is onType #13604

Merged

oxc-bot mentioned this pull request Sep 11, 2025

release(oxlint): v1.15.0 #13685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(language_server): include the diagnostic of the other linter#13490

fix(language_server): include the diagnostic of the other linter#13490
graphite-app[bot] merged 1 commit intomainfrom
08-31-fix_language_server_include_the_diagnostic_of_the_other_linter

Sysix commented Aug 31, 2025 •

edited

Loading

Uh oh!

Sysix commented Aug 31, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Aug 31, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

camc314 commented Sep 2, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

Sysix commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13490 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

camc314 commented Sep 2, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sysix commented Aug 31, 2025 •

edited

Loading

Sysix commented Aug 31, 2025 •

edited

Loading

codspeed-hq bot commented Aug 31, 2025 •

edited

Loading

camc314 commented Sep 2, 2025 •

edited by graphite-app bot

Loading