Skip to content

perf(napi/parser): raw transfer: move check for supported platform#12274

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-14-perf_napi_parser_raw_transfer_move_check_for_supported_platform
Jul 14, 2025
Merged

perf(napi/parser): raw transfer: move check for supported platform#12274
graphite-app[bot] merged 1 commit intomainfrom
07-14-perf_napi_parser_raw_transfer_move_check_for_supported_platform

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 14, 2025

Small optimization to raw transfer. Move check that running on a supported platform out of prepareRaw function (which runs on every call to parseSync) to top level (so we only do the check once). This module is lazy-loaded if user calls parseSync with experimentalRawTransfer, so the check won't run if user is not using raw transfer.

Copy link
Member Author

overlookmotel commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review July 14, 2025 18:42
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Copy link
Member Author

overlookmotel commented Jul 14, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 07-14-refactor_napi_parser_correct_comment_about_raw_transfer_buffer_size to graphite-base/12274 July 14, 2025 18:47
@graphite-app graphite-app bot changed the base branch from graphite-base/12274 to main July 14, 2025 18:55
…12274)

Small optimization to raw transfer. Move check that running on a supported platform out of `prepareRaw` function (which runs on every call to `parseSync`) to top level (so we only do the check once). This module is lazy-loaded if user calls `parseSync` with `experimentalRawTransfer`, so the check won't run if user is not using raw transfer.
@graphite-app graphite-app bot force-pushed the 07-14-perf_napi_parser_raw_transfer_move_check_for_supported_platform branch from 9d4945b to 28be5de Compare July 14, 2025 18:56
@graphite-app graphite-app bot merged commit 28be5de into main Jul 14, 2025
15 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
@graphite-app graphite-app bot deleted the 07-14-perf_napi_parser_raw_transfer_move_check_for_supported_platform branch July 14, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant