refactor(napi/parser): raw transfer: store offsets as consts#12268
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 14, 2025
Merged
Conversation
Member
Author
631a07e to
91b9905
Compare
3d49ab3 to
10f2b27
Compare
10f2b27 to
52f14d2
Compare
52f14d2 to
a3f85ed
Compare
This was referenced Jul 14, 2025
Member
Author
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #12268 will not alter performanceComparing Summary
|
Pure refactor. Instead of hard-coding constants for fixed offsets of data in the buffer, generate these constants in one place and import them from `constants.js` everywhere else.
9d4945b to
28be5de
Compare
a3f85ed to
d009bdb
Compare
Base automatically changed from
07-14-perf_napi_parser_raw_transfer_move_check_for_supported_platform
to
main
July 14, 2025 19:04
graphite-app bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
Pure refactor. Introduce a `RawTransferMetadata` struct to hold metadata that gets written to end of buffer. Codegen use knowledge of memory layout of this struct to generate constants added in #12268. This is more robust than manually calculating offsets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Instead of hard-coding constants for fixed offsets of data in the buffer, generate these constants in one place and import them from
constants.jseverywhere else.