refactor(napi/parser): raw transfer: introduce metadata struct#12269
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 14, 2025
Merged
Conversation
Member
Author
CodSpeed Instrumentation Performance ReportMerging #12269 will not alter performanceComparing Summary
|
10f2b27 to
52f14d2
Compare
ad91492 to
be7c625
Compare
be7c625 to
ae4f6c4
Compare
52f14d2 to
262097f
Compare
This was referenced Jul 14, 2025
Member
Author
Merge activity
|
da6d05d to
0636080
Compare
ae4f6c4 to
b421a66
Compare
Pure refactor. Introduce a `RawTransferMetadata` struct to hold metadata that gets written to end of buffer. Codegen use knowledge of memory layout of this struct to generate constants added in #12268. This is more robust than manually calculating offsets.
0636080 to
39ef911
Compare
b421a66 to
5fba91c
Compare
Base automatically changed from
07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts
to
main
July 14, 2025 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Introduce a
RawTransferMetadatastruct to hold metadata that gets written to end of buffer. Codegen use knowledge of memory layout of this struct to generate constants added in #12268. This is more robust than manually calculating offsets.