Skip to content

refactor(napi/parser): raw transfer: introduce metadata struct#12269

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-14-refactor_napi_parser_introduce_struct_for_metadata
Jul 14, 2025
Merged

refactor(napi/parser): raw transfer: introduce metadata struct#12269
graphite-app[bot] merged 1 commit intomainfrom
07-14-refactor_napi_parser_introduce_struct_for_metadata

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 14, 2025

Pure refactor. Introduce a RawTransferMetadata struct to hold metadata that gets written to end of buffer. Codegen use knowledge of memory layout of this struct to generate constants added in #12268. This is more robust than manually calculating offsets.

Copy link
Member Author

overlookmotel commented Jul 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 14, 2025
@overlookmotel overlookmotel changed the title refactor(napi/parser): introduce struct for metadata refactor(napi/parser): raw transfer: introduce struct for metadata Jul 14, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 14, 2025 14:11
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 14, 2025

CodSpeed Instrumentation Performance Report

Merging #12269 will not alter performance

Comparing 07-14-refactor_napi_parser_introduce_struct_for_metadata (5fba91c) with 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts (39ef911)

Summary

✅ 34 untouched benchmarks

@overlookmotel overlookmotel changed the title refactor(napi/parser): raw transfer: introduce struct for metadata refactor(napi/parser): raw transfer: introduce metadata struct Jul 14, 2025
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_raw_transfer_store_offsets_as_consts branch 2 times, most recently from 10f2b27 to 52f14d2 Compare July 14, 2025 14:32
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_introduce_struct_for_metadata branch from ad91492 to be7c625 Compare July 14, 2025 14:32
@overlookmotel overlookmotel changed the base branch from 07-14-refactor_napi_parser_raw_transfer_store_offsets_as_consts to graphite-base/12269 July 14, 2025 18:43
@overlookmotel overlookmotel force-pushed the 07-14-refactor_napi_parser_introduce_struct_for_metadata branch from be7c625 to ae4f6c4 Compare July 14, 2025 18:43
@overlookmotel overlookmotel changed the base branch from graphite-base/12269 to 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts July 14, 2025 18:43
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Copy link
Member Author

overlookmotel commented Jul 14, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts branch 2 times, most recently from da6d05d to 0636080 Compare July 14, 2025 19:06
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_introduce_struct_for_metadata branch from ae4f6c4 to b421a66 Compare July 14, 2025 19:06
Pure refactor. Introduce a `RawTransferMetadata` struct to hold metadata that gets written to end of buffer. Codegen use knowledge of memory layout of this struct to generate constants added in #12268. This is more robust than manually calculating offsets.
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts branch from 0636080 to 39ef911 Compare July 14, 2025 19:36
@graphite-app graphite-app bot force-pushed the 07-14-refactor_napi_parser_introduce_struct_for_metadata branch from b421a66 to 5fba91c Compare July 14, 2025 19:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 14, 2025
Base automatically changed from 07-14-refactor_napi_parser_allocator_raw_transfer_store_buffer_size_and_align_as_consts to main July 14, 2025 19:45
@graphite-app graphite-app bot merged commit 5fba91c into main Jul 14, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 07-14-refactor_napi_parser_introduce_struct_for_metadata branch July 14, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant