refactor(transformer/styled-components): do not allocate temp data into arena#12198
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 11, 2025
Conversation
Member
Author
CodSpeed Instrumentation Performance ReportMerging #12198 will not alter performanceComparing Summary
|
1dee729 to
daf6087
Compare
9769412 to
5ee93d4
Compare
5ee93d4 to
b20fd6e
Compare
b20fd6e to
3824b83
Compare
3824b83 to
7b6417c
Compare
0928f4a to
bdccba7
Compare
7b6417c to
20854b0
Compare
bdccba7 to
00cd55e
Compare
20854b0 to
7dc1a91
Compare
Member
Author
Merge activity
|
7dc1a91 to
caa2e11
Compare
00cd55e to
e93e4c8
Compare
caa2e11 to
2690913
Compare
…to arena (#12198) Only strings which are part of AST should be stored in arena. Use `String` instead of `StringBuilder` for the temp string here. Ideally we'd use a scratch allocator for temp data to avoid allocations, but we don't have that yet. oxc-project/backlog#121
2690913 to
5ad62cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Only strings which are part of AST should be stored in arena. Use
Stringinstead ofStringBuilderfor the temp string here.Ideally we'd use a scratch allocator for temp data to avoid allocations, but we don't have that yet. oxc-project/backlog#121