test(transformer/styled-components): add failing test case for comment removal#12202
Merged
graphite-app[bot] merged 1 commit intomainfrom Jul 11, 2025
Conversation
Member
Author
7feef3d to
8745c89
Compare
7baf7ca to
7b1f4a5
Compare
8745c89 to
6749f11
Compare
6749f11 to
75fb8cc
Compare
75fb8cc to
a2be0e0
Compare
This was referenced Jul 11, 2025
Dunqing
approved these changes
Jul 11, 2025
Member
Author
Merge activity
|
…t removal (#12202) Failing test case which demonstrates a bug with comments removal from CSS. The last 2 expressions are in wrong order. Problem is likely `swap_remove`, which alters order of the `Vec`'s elements: https://github.com/oxc-project/oxc/blob/86eb10882eeacbe05a0dc5e0e3adfad9a9890821/crates/oxc_transformer/src/plugins/styled_components.rs#L407-L412
ac177b4 to
9a20cde
Compare
a2be0e0 to
47ff2bb
Compare
Base automatically changed from
07-11-perf_transformer_styled-components_cache_block_name
to
main
July 11, 2025 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Failing test case which demonstrates a bug with comments removal from CSS. The last 2 expressions are in wrong order.
Problem is likely
swap_remove, which alters order of theVec's elements:oxc/crates/oxc_transformer/src/plugins/styled_components.rs
Lines 407 to 412 in 86eb108