Skip to content

perf(transformer/styled-components): cache more of component IDs#12195

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-10-perf_transformer_styled-components_cache_more_of_component_ids
Jul 10, 2025
Merged

perf(transformer/styled-components): cache more of component IDs#12195
graphite-app[bot] merged 1 commit intomainfrom
07-10-perf_transformer_styled-components_cache_more_of_component_ids

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jul 10, 2025

Everything before the component counter is the same for every component ID. So build the prefix once and cache it, instead of caching just the file hash.

Also, don't store this temporary value in arena.

Copy link
Member Author

overlookmotel commented Jul 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Jul 10, 2025
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jul 10, 2025
@overlookmotel overlookmotel marked this pull request as ready for review July 10, 2025 15:25
@overlookmotel overlookmotel requested a review from Dunqing as a code owner July 10, 2025 15:25
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2025

CodSpeed Instrumentation Performance Report

Merging #12195 will not alter performance

Comparing 07-10-perf_transformer_styled-components_cache_more_of_component_ids (c35fe73) with main (4118b96)

Summary

✅ 34 untouched benchmarks

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 10, 2025

Merge activity

)

Everything before the component counter is the same for every component ID. So build the prefix once and cache it, instead of caching just the file hash.

Also, don't store this temporary value in arena.
@graphite-app graphite-app bot force-pushed the 07-10-perf_transformer_styled-components_cache_more_of_component_ids branch from 8ebf06b to c35fe73 Compare July 10, 2025 16:13
@graphite-app graphite-app bot merged commit c35fe73 into main Jul 10, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 10, 2025
@graphite-app graphite-app bot deleted the 07-10-perf_transformer_styled-components_cache_more_of_component_ids branch July 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants