Skip to content

refactor(allocator)!: remove String#11262

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-23-refactor_allocator_remove_string_
May 24, 2025
Merged

refactor(allocator)!: remove String#11262
graphite-app[bot] merged 1 commit intomainfrom
05-23-refactor_allocator_remove_string_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 24, 2025

Previous PRs have removed all uses of String from the codebase, replacing it with StringBuilder. Now remove String entirely.

Copy link
Member Author

overlookmotel commented May 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 24, 2025

CodSpeed Instrumentation Performance Report

Merging #11262 will degrade performances by 22.52%

Comparing 05-23-refactor_allocator_remove_string_ (c16ea02) with 05-23-refactor_transformer_use_stringbuilder_instead_of_string_ (202ffd2)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 2.7 ms 3.5 ms -22.52%

@overlookmotel overlookmotel marked this pull request as ready for review May 24, 2025 01:42
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 24, 2025
Copy link
Member

Boshen commented May 24, 2025

Merge activity

Previous PRs have removed all uses of `String` from the codebase, replacing it with `StringBuilder`. Now remove `String` entirely.
@graphite-app graphite-app bot force-pushed the 05-23-refactor_transformer_use_stringbuilder_instead_of_string_ branch from 7f10c31 to 202ffd2 Compare May 24, 2025 02:34
@graphite-app graphite-app bot requested a review from Dunqing as a code owner May 24, 2025 02:34
@graphite-app graphite-app bot force-pushed the 05-23-refactor_allocator_remove_string_ branch from e8ba1c7 to c16ea02 Compare May 24, 2025 02:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 24, 2025
Base automatically changed from 05-23-refactor_transformer_use_stringbuilder_instead_of_string_ to main May 24, 2025 02:43
@graphite-app graphite-app bot merged commit c16ea02 into main May 24, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 05-23-refactor_allocator_remove_string_ branch May 24, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants