Skip to content

refactor(parser): use StringBuilder instead of String#11259

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-23-refactor_parser_use_stringbuilder_instead_of_string_
May 24, 2025
Merged

refactor(parser): use StringBuilder instead of String#11259
graphite-app[bot] merged 1 commit intomainfrom
05-23-refactor_parser_use_stringbuilder_instead_of_string_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 23, 2025

Replace usage of String with StringBuilder (introduced in #11257) in parser.

Copy link
Member Author

overlookmotel commented May 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-parser Area - Parser label May 23, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 23, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 23, 2025 22:18
@codspeed-hq
Copy link

codspeed-hq bot commented May 23, 2025

CodSpeed Instrumentation Performance Report

Merging #11259 will degrade performances by 13.03%

Comparing 05-23-refactor_parser_use_stringbuilder_instead_of_string_ (02d3bb7) with 05-23-refactor_ast_span_use_stringbuilder_instead_of_string_ (f406202)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -13.03%

@overlookmotel overlookmotel changed the base branch from 05-23-refactor_ast_span_use_stringbuilder_instead_of_string_ to graphite-base/11259 May 24, 2025 00:59
@overlookmotel overlookmotel force-pushed the 05-23-refactor_parser_use_stringbuilder_instead_of_string_ branch from 447d22e to dc1afcb Compare May 24, 2025 01:05
@overlookmotel overlookmotel force-pushed the graphite-base/11259 branch from 2c3ab9e to 07d28d7 Compare May 24, 2025 01:05
@overlookmotel overlookmotel changed the base branch from graphite-base/11259 to 05-23-refactor_ast_span_use_stringbuilder_instead_of_string_ May 24, 2025 01:05
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 24, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 24, 2025

Merge activity

Replace usage of `String` with `StringBuilder` (introduced in #11257) in parser.
@graphite-app graphite-app bot force-pushed the 05-23-refactor_ast_span_use_stringbuilder_instead_of_string_ branch from 07d28d7 to f406202 Compare May 24, 2025 02:33
@graphite-app graphite-app bot requested a review from Dunqing as a code owner May 24, 2025 02:33
@graphite-app graphite-app bot force-pushed the 05-23-refactor_parser_use_stringbuilder_instead_of_string_ branch from dc1afcb to 02d3bb7 Compare May 24, 2025 02:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 24, 2025
Base automatically changed from 05-23-refactor_ast_span_use_stringbuilder_instead_of_string_ to main May 24, 2025 02:41
@graphite-app graphite-app bot merged commit 02d3bb7 into main May 24, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-23-refactor_parser_use_stringbuilder_instead_of_string_ branch May 24, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant