feat(span): add Atom::from_strs_array_in method#11261
Merged
graphite-app[bot] merged 1 commit intomainfrom May 24, 2025
Merged
Conversation
This was referenced May 24, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11261 will improve performances by 13.52%Comparing Summary
Benchmarks breakdown
|
Contributor
Merge activity
|
Add `Atom::from_strs_array_in` method, to complement `String::from_strs_array_in`. In many places we were using `String::from_strs_array_in` only as a means to get an `Atom`. Cut out the middleman! This prepares the way for #11260, and getting rid of `String` entirely.
5bc76b5 to
254048d
Compare
91b20f5 to
4feeeee
Compare
Base automatically changed from
05-23-perf_lexer_remove_string_allocation
to
main
May 24, 2025 02:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add
Atom::from_strs_array_inmethod, to complementString::from_strs_array_in. In many places we were usingString::from_strs_array_inonly as a means to get anAtom. Cut out the middleman!This prepares the way for #11260, and getting rid of
Stringentirely.