Skip to content

fix(isolated-declarations): type of class setter/getter cannot be inferred when the key is a global Symbol.xxx expression#11236

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression
May 23, 2025
Merged

fix(isolated-declarations): type of class setter/getter cannot be inferred when the key is a global Symbol.xxx expression#11236
graphite-app[bot] merged 1 commit intomainfrom
05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented May 22, 2025

Similar to #11229, using PropertyKey to store accessor annotation because [Symbol.xxx] is not a static name.

Copy link
Member Author

Dunqing commented May 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Instrumentation Performance Report

Merging #11236 will not alter performance

Comparing 05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression (7126adb) with 05-22-fix_isolated-declarations_object_property_key_was_generated_incorrectly (ac9638e)

Summary

✅ 34 untouched benchmarks
🆕 4 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 149.1 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 54.7 ms N/A

@Dunqing Dunqing force-pushed the 05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression branch from 5dc3cb3 to 1e542b6 Compare May 22, 2025 23:53
@Dunqing Dunqing marked this pull request as ready for review May 22, 2025 23:54
@Dunqing Dunqing force-pushed the 05-22-fix_isolated-declarations_object_property_key_was_generated_incorrectly branch from 29c8e12 to 57ab474 Compare May 23, 2025 03:24
@Dunqing Dunqing force-pushed the 05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression branch from 1e542b6 to 255ce64 Compare May 23, 2025 03:24
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 23, 2025
Copy link
Member

Boshen commented May 23, 2025

Merge activity

…erred when the key is a global `Symbol.xxx` expression (#11236)

Similar to #11229, using `PropertyKey` to store accessor annotation because `[Symbol.xxx]` is not a static name.
@graphite-app graphite-app bot force-pushed the 05-22-fix_isolated-declarations_object_property_key_was_generated_incorrectly branch from 57ab474 to ac9638e Compare May 23, 2025 11:52
@graphite-app graphite-app bot force-pushed the 05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression branch from 255ce64 to 7126adb Compare May 23, 2025 11:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 23, 2025
Base automatically changed from 05-22-fix_isolated-declarations_object_property_key_was_generated_incorrectly to main May 23, 2025 11:58
@graphite-app graphite-app bot merged commit 7126adb into main May 23, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-23-fix_isolated-declarations_type_of_class_setter_getter_cannot_be_inferred_when_the_key_is_a_global_symbol.xxx_expression branch May 23, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants