fix(isolated-declarations): incorrect type of object property accessor#11229
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
57cd5a9 to
c4b71d8
Compare
46e9d6f to
699ec64
Compare
CodSpeed Instrumentation Performance ReportMerging #11229 will degrade performances by 12.29%Comparing Summary
Benchmarks breakdown
|
c4b71d8 to
109dcf6
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with the type inference of object property accessors within isolated declarations. It updates the test snapshots and fixtures to capture errors related to accessor types and refactors the logic in the type inference function in src/types.rs.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_isolated_declarations/tests/snapshots/object.snap | Adds a new snapshot verifying error output |
| crates/oxc_isolated_declarations/tests/fixtures/object.ts | Updates test fixtures for object accessors |
| crates/oxc_isolated_declarations/src/types.rs | Refactors accessor type inference logic |
Merge activity
|
109dcf6 to
9ec8500
Compare

close: #11186