Skip to content

fix(isolated-declarations): incorrect type of object property accessor#11229

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor
May 23, 2025
Merged

fix(isolated-declarations): incorrect type of object property accessor#11229
graphite-app[bot] merged 1 commit intomainfrom
05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented May 22, 2025

close: #11186

@github-actions github-actions bot added the A-isolated-declarations Isolated Declarations label May 22, 2025
@github-actions github-actions bot added the C-bug Category - Bug label May 22, 2025
Copy link
Member Author

Dunqing commented May 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the base branch from 05-20-feat_formatter_support_printing_binary_like_expression to graphite-base/11229 May 22, 2025 07:50
@Dunqing Dunqing force-pushed the 05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor branch from 57cd5a9 to c4b71d8 Compare May 22, 2025 07:50
@Dunqing Dunqing force-pushed the graphite-base/11229 branch from 46e9d6f to 699ec64 Compare May 22, 2025 07:50
@Dunqing Dunqing changed the base branch from graphite-base/11229 to main May 22, 2025 07:50
@codspeed-hq
Copy link

codspeed-hq bot commented May 22, 2025

CodSpeed Instrumentation Performance Report

Merging #11229 will degrade performances by 12.29%

Comparing 05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor (9ec8500) with main (4e12796)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -12.29%

@Dunqing Dunqing force-pushed the 05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor branch from c4b71d8 to 109dcf6 Compare May 22, 2025 23:43
@Dunqing Dunqing marked this pull request as ready for review May 22, 2025 23:47
Copilot AI review requested due to automatic review settings May 22, 2025 23:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes an issue with the type inference of object property accessors within isolated declarations. It updates the test snapshots and fixtures to capture errors related to accessor types and refactors the logic in the type inference function in src/types.rs.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/oxc_isolated_declarations/tests/snapshots/object.snap Adds a new snapshot verifying error output
crates/oxc_isolated_declarations/tests/fixtures/object.ts Updates test fixtures for object accessors
crates/oxc_isolated_declarations/src/types.rs Refactors accessor type inference logic

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 23, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 23, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor branch from 109dcf6 to 9ec8500 Compare May 23, 2025 11:51
graphite-app bot pushed a commit that referenced this pull request May 23, 2025
…erred when the key is a global `Symbol.xxx` expression (#11236)

Similar to #11229, using `PropertyKey` to store accessor annotation because `[Symbol.xxx]` is not a static name.
@graphite-app graphite-app bot merged commit 9ec8500 into main May 23, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 23, 2025
@graphite-app graphite-app bot deleted the 05-22-fix_isolated-declarations_incorrect_type_of_object_property_accessor branch May 23, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-isolated-declarations Isolated Declarations C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isolated Declarations: bug with type getters being generated as functions

2 participants