fix(isolated-declarations): object property key was generated incorrectly#11231
Merged
graphite-app[bot] merged 1 commit intomainfrom May 23, 2025
Conversation
This was referenced May 22, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
9674d51 to
797cb04
Compare
1cce8d8 to
3198d49
Compare
CodSpeed Instrumentation Performance ReportMerging #11231 will not alter performanceComparing Summary
|
3198d49 to
f8622ef
Compare
797cb04 to
29c8e12
Compare
29c8e12 to
57ab474
Compare
Contributor
Merge activity
|
…ctly (#11231) Just for aligning with `TypeScript`, the object key should be converted to a static property key when possible ```ts const ObjectKeys = { a: 0, ["b"]: 1, [`c`]: 2, [3]: 3, [-3]: 4, [4n]: 5, }; ``` ```ts declare const ObjectKeys: { a: number b: number c: number 3: number [-3]: number }; ``` `BigInt` is invalid as a property key in TypeScript, so `4n` doesn't emit.
f8622ef to
123e63c
Compare
57ab474 to
ac9638e
Compare
Base automatically changed from
05-22-feat_isolated-declarations_report_an_error_for_object_methods_whose_return_type_cannot_be_inferred
to
main
May 23, 2025 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Just for aligning with
TypeScript, the object key should be converted to a static property key when possibleBigIntis invalid as a property key in TypeScript, so4ndoesn't emit.