fix(ast_visit): fix visitation order for TSTemplateLiteralType in Utf8ToUtf16Converter#11007
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 13, 2025
CodSpeed Instrumentation Performance ReportMerging #11007 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
35caa35 to
53a2430
Compare
3c210ef to
021aa8b
Compare
Contributor
Merge activity
|
…Utf8ToUtf16Converter` (#11007) Fix visitation order in `Utf8ToUtf16Converter` to process span offsets in ascending order in `TSTemplateLiteralType`. `quasis` and `types` are interleaved, so to visit them in source order, need to visit `quasis[0]`, `types[0]`, `quasis[1]`, `types[1]`, `quasis[2]`, etc.
021aa8b to
d0d04e3
Compare
53a2430 to
282420c
Compare
Base automatically changed from
05-12-fix_ast_visit_fix_visitation_order_for_bindingpattern_in_utf8toutf16converter_
to
main
May 14, 2025 01:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix visitation order in
Utf8ToUtf16Converterto process span offsets in ascending order inTSTemplateLiteralType.quasisandtypesare interleaved, so to visit them in source order, need to visitquasis[0],types[0],quasis[1],types[1],quasis[2], etc.